Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Filebeat] Update checkpoint.source_object mapping #25145

Merged
merged 3 commits into from
Apr 26, 2021

Conversation

legoguy1000
Copy link
Contributor

What does this PR do?

Changes checkpoint.source_object from Long to Keyword per https://supportcenter.checkpoint.com/supportcenter/portal?eventSubmit_doGoviewsolutiondetails=&solutionid=sk144192

Why is it important?

Field should be a string, not number

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

cd x-pack/filebeat
TESTING_FILEBEAT_MODULES=checkpoint mage -v pythonIntegTest

Related issues

Use cases

Screenshots

Logs

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Apr 19, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Apr 19, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: andrewkroh commented: run tests

  • Start Time: 2021-04-26T14:49:22.492+0000

  • Duration: 106 min 32 sec

  • Commit: 494f58d

Test stats 🧪

Test Results
Failed 0
Passed 13707
Skipped 2285
Total 15992

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 13707
Skipped 2285
Total 15992

@legoguy1000 legoguy1000 marked this pull request as ready for review April 19, 2021 17:40
@legoguy1000
Copy link
Contributor Author

@andrewkroh @andrewstucki could you run the CI tests?

@andrewkroh
Copy link
Member

run tests

@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Apr 21, 2021
@legoguy1000
Copy link
Contributor Author

@andrewkroh I think we're good to merge unless you have any comments.

@andrewkroh
Copy link
Member

run tests

@legoguy1000
Copy link
Contributor Author

Looks like all the tests passed

@andrewkroh
Copy link
Member

I suspected that this fail after it merged to master because in master I pinned the geoip database version which affected the contents of the generated files. So I updated the branch and regenerated the test output files.

@andrewkroh
Copy link
Member

run tests

@andrewkroh andrewkroh merged commit a5e6e5b into elastic:master Apr 26, 2021
@andrewkroh andrewkroh added the backport-v7.14.0 Automated backport with mergify label Apr 26, 2021
mergify bot pushed a commit that referenced this pull request Apr 26, 2021
* #25124: Update `checkpoint.source_object` mapping

* Update generated

Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
(cherry picked from commit a5e6e5b)
andrewkroh pushed a commit that referenced this pull request Apr 26, 2021
* #25124: Update `checkpoint.source_object` mapping

* Update generated

Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
(cherry picked from commit a5e6e5b)

Co-authored-by: Alex Resnick <adr8292@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v7.14.0 Automated backport with mergify Filebeat Filebeat review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Check Point] Field checkpoint.source_object mapped incorrectly as long
4 participants