Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Winlogbeat] Update experimental flag on winlogbeat documentation #25207

Merged
merged 1 commit into from
Apr 22, 2021

Conversation

leehinman
Copy link
Contributor

  • remove experimental from batch_read_size
  • remove experimental from api (using wineventlog-experimental) is
    still experimental but setting the API isn't
  • syncs with documentation for agent winlog input

What does this PR do?

Update winlog documentation

  • remove experimental from batch_read_size
  • remove experimental from api (using wineventlog-experimental) is
    still experimental but setting the API isn't
  • syncs with documentation for agent winlog input

Why is it important?

Setting these options is GA. Note that using the
wineventlog-experimental setting for api is still considered
experimental.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

- remove experimental from batch_read_size
- remove experimental from api (using wineventlog-experimental) is
  still experimental but setting the API isn't
- syncs with documentation for agent winlog input
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Apr 21, 2021
@leehinman leehinman added backport-v7.13.0 Automated backport with mergify backport-v7.14.0 Automated backport with mergify docs needs_backport PR is waiting to be backported to other branches. Team:Security-External Integrations Winlogbeat labels Apr 21, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Apr 21, 2021
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #25207 opened

  • Start Time: 2021-04-21T15:41:12.626+0000

  • Duration: 29 min 6 sec

  • Commit: 6a8fe0a

Trends 🧪

Image of Build Times

❕ Flaky test report

No test was executed to be analysed.

@leehinman leehinman merged commit 639998c into elastic:master Apr 22, 2021
mergify bot pushed a commit that referenced this pull request Apr 22, 2021
- remove experimental from batch_read_size
- remove experimental from api (using wineventlog-experimental) is
  still experimental but setting the API isn't
- syncs with documentation for agent winlog input

(cherry picked from commit 639998c)
mergify bot pushed a commit that referenced this pull request Apr 22, 2021
- remove experimental from batch_read_size
- remove experimental from api (using wineventlog-experimental) is
  still experimental but setting the API isn't
- syncs with documentation for agent winlog input

(cherry picked from commit 639998c)
leehinman added a commit that referenced this pull request Apr 22, 2021
- remove experimental from batch_read_size
- remove experimental from api (using wineventlog-experimental) is
  still experimental but setting the API isn't
- syncs with documentation for agent winlog input

(cherry picked from commit 639998c)

Co-authored-by: Lee Hinman <57081003+leehinman@users.noreply.github.com>
leehinman added a commit that referenced this pull request Apr 22, 2021
- remove experimental from batch_read_size
- remove experimental from api (using wineventlog-experimental) is
  still experimental but setting the API isn't
- syncs with documentation for agent winlog input

(cherry picked from commit 639998c)

Co-authored-by: Lee Hinman <57081003+leehinman@users.noreply.github.com>
@leehinman leehinman deleted the update_winlogbeat_options branch April 22, 2021 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v7.13.0 Automated backport with mergify backport-v7.14.0 Automated backport with mergify docs needs_backport PR is waiting to be backported to other branches. Winlogbeat
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants