Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Elastic Agent] Don't log when upgrade capability doesn't apply #25386

Merged
merged 3 commits into from
Apr 28, 2021
Merged

[Elastic Agent] Don't log when upgrade capability doesn't apply #25386

merged 3 commits into from
Apr 28, 2021

Conversation

blakerouse
Copy link
Contributor

@blakerouse blakerouse commented Apr 28, 2021 •
edited
Loading

What does this PR do?

Don't log when upgrade capability doesn't apply, as it causes confusion that an actual error is happening. When it's not really an error and totally acceptable.

Why is it important?

It is currently really confusing that this is logged.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@blakerouse blakerouse added Team:Elastic-Agent Label for the Agent team backport-v7.13.0 Automated backport with mergify backport-v7.14.0 Automated backport with mergify labels Apr 28, 2021
@blakerouse blakerouse self-assigned this Apr 28, 2021
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Apr 28, 2021
@blakerouse blakerouse marked this pull request as ready for review April 28, 2021 14:20
@elasticmachine
Copy link
Collaborator

Pinging @elastic/agent (Team:Agent)

ruflin
ruflin approved these changes Apr 28, 2021
View reviewed changes
Copy link
Member

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We might need to add some debug logs for all the capabilities in the future.

@elasticmachine
Copy link
Collaborator

elasticmachine commented Apr 28, 2021 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #25386 updated

  • Start Time: 2021-04-28T14:21:17.522+0000

  • Duration: 104 min 2 sec

  • Commit: 926901e

Test stats 🧪

Test Results
Failed 0
Passed 6788
Skipped 16
Total 6804

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 6788
Skipped 16
Total 6804

@blakerouse blakerouse merged commit 5a5fa15 into elastic:master Apr 28, 2021
@blakerouse blakerouse deleted the fix-capabilities branch April 28, 2021 16:32
mergify bot pushed a commit that referenced this pull request Apr 28, 2021
@blakerouse
[Elastic Agent] Don't log when upgrade capability doesn't apply (#25386)
917b331 
* Fix #25302.

* Add changelog entry.

(cherry picked from commit 5a5fa15)
@mergify mergify bot mentioned this pull request Apr 28, 2021
Merged
mergify bot pushed a commit that referenced this pull request Apr 28, 2021
@blakerouse
[Elastic Agent] Don't log when upgrade capability doesn't apply (#25386)
208c78c 
* Fix #25302.

* Add changelog entry.

(cherry picked from commit 5a5fa15)
@mergify mergify bot mentioned this pull request Apr 28, 2021
Merged
blakerouse added a commit that referenced this pull request Apr 28, 2021
@mergify @blakerouse
[Elastic Agent] Don't log when upgrade capability doesn't apply (#25386…
01a655c 
…) (#25399)

* Fix #25302.

* Add changelog entry.

(cherry picked from commit 5a5fa15)

Co-authored-by: Blake Rouse <blake.rouse@elastic.co>
blakerouse added a commit that referenced this pull request Apr 29, 2021
@mergify @blakerouse
[Elastic Agent] Don't log when upgrade capability doesn't apply (#25386…
d054612 
…) (#25400)

* Fix #25302.

* Add changelog entry.

(cherry picked from commit 5a5fa15)

Co-authored-by: Blake Rouse <blake.rouse@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruflin ruflin ruflin approved these changes

Assignees

@blakerouse blakerouse

Labels
backport-v7.13.0 Automated backport with mergify backport-v7.14.0 Automated backport with mergify Team:Elastic-Agent Label for the Agent team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[elastic-agent] Configuration changes cannot be applied
3 participants
@blakerouse @elasticmachine @ruflin