libbeat: add support for defining unit and metric_type field metadata in ES templates #25419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Unit and MetricType properties to Field, which may be set to "standard" unit and metric type metadata values to aid in interpretation of the data.
botelastic
bot
added
the
needs_team
botelastic
bot
removed
the
needs_team
axw
changed the title
axw
commented
Apr 29, 2021
| return fmt.Errorf("no format expected for field %s, found: %s", f.Name, f.Format) | ||
| } | ||
| allowedFormatters = []string{"date_range"} | ||
| case "boolean", "binary", "ip", "alias", "array": |
There was a problem hiding this comment.
I have moved "histogram" up to the numeric types
|
Pinging @elastic/agent (Team:Agent) |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
exekias
suggested changes
Apr 29, 2021
|
For the record, we added this also to the package spec, I'm glad the we are using the same field names, so things are compatible between beats and packages 🎉 elastic/package-spec#42 |
exekias
approved these changes
Apr 30, 2021
mergify bot
pushed a commit
that referenced
this pull request
May 1, 2021
… in ES templates (#25419) * libbeat/mapping: add Unit and MetricType to Field Add Unit and MetricType properties to Field, which may be set to "standard" unit and metric type metadata values to aid in interpretation of the data. * libbeat/template: add meta.{metric_type,unit} (cherry picked from commit 23c546e)
axw
added a commit
that referenced
this pull request
May 3, 2021
… in ES templates (#25419) (#25479) * libbeat/mapping: add Unit and MetricType to Field Add Unit and MetricType properties to Field, which may be set to "standard" unit and metric type metadata values to aid in interpretation of the data. * libbeat/template: add meta.{metric_type,unit} (cherry picked from commit 23c546e) Co-authored-by: Andrew Wilkins <axw@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add optional
unitandmetric_typeproperties to fields in fields.yml, which are used to set field metadata in Elasticsearch templates. These are allowed only for numeric field types, and we check the values against those defined in the Elasticsearch docs at https://www.elastic.co/guide/en/elasticsearch/reference/current/mapping-field-meta.htmlWhy is it important?
We would like to add unit/metric_type field metadata in fields defined by APM Server.
Checklist
- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration filesCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.