Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use working set bytes if usage bytes is zero #25428

Merged
merged 10 commits into from
Apr 30, 2021
Merged

Use working set bytes if usage bytes is zero #25428

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
0e8ce05
Use working set bytes if usage bytes is zero
brianharwell Apr 29, 2021
94dea08
Update CHANGELOG.asciidoc
brianharwell Apr 29, 2021
f54606c
Add comment to CHANGELOG.next.asciidoc
brianharwell Apr 30, 2021
e713226
Moved comment to bug fixes
brianharwell Apr 30, 2021
dc4b6ab
Calculate pod memory pct based on field existence
brianharwell Apr 30, 2021
8f65818
Updated description of change
brianharwell Apr 30, 2021
5da426f
Remove unneeded lines
brianharwell Apr 30, 2021
0112df2
I removed too many lines
brianharwell Apr 30, 2021
cf07d3d
More removals
brianharwell Apr 30, 2021
f5bad30
Merge branch 'master' of https://github.com/elastic/beats into window…
brianharwell Apr 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.next.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -506,6 +506,7 @@ https://github.com/elastic/beats/compare/v7.0.0-alpha2...master[Check the HEAD d
- Fix GCP not able to request Cloudfunctions metrics if a region filter was set {pull}24218[24218]
- Fix type of `uwsgi.status.worker.rss` type. {pull}24468[24468]
- Accept text/plain type by default for prometheus client scraping. {pull}24622[24622]
- Use working set bytes to calculate the pod memory limit pct when memory usage is not reported (ie. Windows pods). {pull}25428[25428]

*Packetbeat*

Expand Down
18 changes: 14 additions & 4 deletions metricbeat/module/kubernetes/pod/data.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,12 +122,22 @@ func eventMapping(content []byte, perfMetrics *util.PerfMetricsCache) ([]common.
podEvent.Put("memory.usage.node.pct", float64(usageMem)/nodeMem)
}

if coresLimit > 0 {
podEvent.Put("cpu.usage.limit.pct", float64(usageNanoCores)/1e9/coresLimit)
jsoriano marked this conversation as resolved.
Show resolved Hide resolved
if usageMem > 0 {
if nodeMem > 0 {
podEvent.Put("memory.usage.node.pct", float64(usageMem)/nodeMem)
}
if memLimit > 0 {
podEvent.Put("memory.usage.limit.pct", float64(usageMem)/memLimit)
}
jsoriano marked this conversation as resolved.
Show resolved Hide resolved
}

if memLimit > 0 {
podEvent.Put("memory.usage.limit.pct", float64(usageMem)/memLimit)
if workingSet > 0 && usageMem == 0 {
if nodeMem > 0 {
podEvent.Put("memory.usage.node.pct", float64(workingSet)/nodeMem)
}
if memLimit > 0 {
podEvent.Put("memory.usage.limit.pct", float64(workingSet)/memLimit)
}
}

events = append(events, podEvent)
Expand Down