Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Elastic Agent] Remove deprecated --kibana-url. #25529

Merged
merged 2 commits into from
May 10, 2021

Conversation

blakerouse
Copy link
Contributor

@blakerouse blakerouse commented May 4, 2021

What does this PR do?

Removes the --kibana-url from the install and enroll commands. This was original kept in to not break everyone as we switched to Fleet Server. Now with complete transition to Fleet Server this should be removed because it is confusing as it can now never point to Kibana.

Why is it important?

So its not confusing and so that --url is the only way forward.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@blakerouse blakerouse added Team:Elastic-Agent Label for the Agent team backport-v7.14.0 Automated backport with mergify labels May 4, 2021
@blakerouse blakerouse self-assigned this May 4, 2021
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels May 4, 2021
@botelastic
Copy link

botelastic bot commented May 4, 2021

This pull request doesn't have a Team:<team> label.

@blakerouse blakerouse marked this pull request as ready for review May 4, 2021 13:02
@elasticmachine
Copy link
Collaborator

Pinging @elastic/agent (Team:Agent)

@elasticmachine
Copy link
Collaborator

elasticmachine commented May 4, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #25529 updated

  • Start Time: 2021-05-04T13:02:33.799+0000

  • Duration: 103 min 41 sec

  • Commit: 1bdc10f

Test stats 🧪

Test Results
Failed 0
Passed 6781
Skipped 23
Total 6804

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 6781
Skipped 23
Total 6804

Copy link
Member

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ph @urso I suggest we reach out to all the teams to validate this flag is not used anymore and then also backport it to 7.13.

@ph
Copy link
Contributor

ph commented May 10, 2021

@blake-kephart Let's merge, @mdelapenya and @mtojek I think we have already adjusted the CI to now use the above flag?

@blakerouse blakerouse added the backport-v7.13.0 Automated backport with mergify label May 10, 2021
@blakerouse blakerouse merged commit 48d7ba1 into elastic:master May 10, 2021
@blakerouse blakerouse deleted the agent-remove-kibana-url branch May 10, 2021 14:54
mergify bot pushed a commit that referenced this pull request May 10, 2021
* Remove deprecated --kibana-url.

* Add changelog.

(cherry picked from commit 48d7ba1)
mergify bot pushed a commit that referenced this pull request May 10, 2021
* Remove deprecated --kibana-url.

* Add changelog.

(cherry picked from commit 48d7ba1)
@mdelapenya
Copy link
Contributor

Confirmed that the e2e tests are not using that flag in master, will check backports for 7.x and 7.13.x

blakerouse added a commit that referenced this pull request May 10, 2021
* Remove deprecated --kibana-url.

* Add changelog.

(cherry picked from commit 48d7ba1)

Co-authored-by: Blake Rouse <blake.rouse@elastic.co>
blakerouse added a commit that referenced this pull request May 10, 2021
* Remove deprecated --kibana-url.

* Add changelog.

(cherry picked from commit 48d7ba1)

Co-authored-by: Blake Rouse <blake.rouse@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v7.13.0 Automated backport with mergify backport-v7.14.0 Automated backport with mergify Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants