-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Elastic Agent] Remove deprecated --kibana-url. #25529
[Elastic Agent] Remove deprecated --kibana-url. #25529
Conversation
This pull request doesn't have a |
Pinging @elastic/agent (Team:Agent) |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@blake-kephart Let's merge, @mdelapenya and @mtojek I think we have already adjusted the CI to now use the above flag? |
* Remove deprecated --kibana-url. * Add changelog. (cherry picked from commit 48d7ba1)
* Remove deprecated --kibana-url. * Add changelog. (cherry picked from commit 48d7ba1)
Confirmed that the e2e tests are not using that flag in master, will check backports for 7.x and 7.13.x |
What does this PR do?
Removes the
--kibana-url
from theinstall
andenroll
commands. This was original kept in to not break everyone as we switched to Fleet Server. Now with complete transition to Fleet Server this should be removed because it is confusing as it can now never point to Kibana.Why is it important?
So its not confusing and so that
--url
is the only way forward.Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.