Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x](backport #25422) libbeat: support explicit dynamic templates #25570

Merged
merged 1 commit into from
May 6, 2021

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 6, 2021

This is an automatic backport of pull request #25422 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.io/

* libbeat: support explicit dynamic templates

Add the field `DynamicTemplate bool` to `mapping.Field`,
indicating that the field represents an explicitly named
dynamic template. Update Elasticsearch template generation
to create dynamic templates from these fields when the
target Elasticsearch is 7.13.0+, when support for these
dynamic templates was added and the requirement of match
criteria was dropped.

Such dynamic templates are suitable only for use in
dynamic_templates bulk request parameters and in ingest
pipelines; they will have no path or type matching criteria.

* Update changelog

* Revert signature change

* Disallow dynamic_template with object_type_params

* Add a constant for min version

* libbeat/mapping: fix field validation

(cherry picked from commit 7a49ca1)
@mergify mergify bot added the backport label May 6, 2021
@mergify mergify bot assigned axw May 6, 2021
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 6, 2021
@botelastic
Copy link

botelastic bot commented May 6, 2021

This pull request doesn't have a Team:<team> label.

@elasticmachine
Copy link
Collaborator

elasticmachine commented May 6, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: axw commented: /test

  • Start Time: 2021-05-06T06:45:39.597+0000

  • Duration: 77 min 1 sec

  • Commit: 889a800

Test stats 🧪

Test Results
Failed 0
Passed 1531
Skipped 234
Total 1765

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 1531
Skipped 234
Total 1765

@axw
Copy link
Member

axw commented May 6, 2021

/test

@axw
Copy link
Member

axw commented May 6, 2021

@Mergifyio update

@mergify
Copy link
Contributor Author

mergify bot commented May 6, 2021

Command update: success

Branch already up to date

@axw
Copy link
Member

axw commented May 6, 2021

/test

@axw axw merged commit 712398e into 7.x May 6, 2021
@axw axw deleted the mergify/bp/7.x/pr-25422 branch May 6, 2021 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants