Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update MSSQL Server linux image's Docker registry #26440

Merged
merged 2 commits into from
Jun 24, 2021
Merged

fix: update MSSQL Server linux image's Docker registry #26440

merged 2 commits into from
Jun 24, 2021

Conversation

mdelapenya
Copy link
Contributor

@mdelapenya mdelapenya commented Jun 23, 2021 •
edited
Loading

What does this PR do?

  • It adds metricbeat's MSSQL to the supported-versions model, adding the supported-versions.yml file.
  • It updated the Docker tag, as 2017-GA is not present anymore, in favour of 2017-GA-ubuntu. There are more images such as 2019-GA-ubuntu-16.04. Please see https://mcr.microsoft.com/v2/mssql/server/tags/list)
  • It updates the Docker registry, from Docker Hub to Microsoft's one.

Why is it important?

System tests for xpack/metricbeat were failing.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

cd x-pack/metricbeat
MODULE=mssql mage compose:buildSupportedVersions
MODULE=mssql mage compose:pushSupportedVersions

Related issues

Follow-ups

We could add this integration to the e2e test suite

@mdelapenya mdelapenya self-assigned this Jun 23, 2021
@mdelapenya mdelapenya added the Team:Automation Label for the Observability productivity team label Jun 23, 2021
@mdelapenya mdelapenya requested a review from a team June 23, 2021 11:55
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jun 23, 2021
@botelastic
Copy link

botelastic bot commented Jun 23, 2021

This pull request doesn't have a Team:<team> label.

@mdelapenya mdelapenya requested a review from jsoriano June 23, 2021 11:57
@mdelapenya mdelapenya added the Team:Integrations Label for the Integrations team label Jun 23, 2021
@mdelapenya mdelapenya marked this pull request as ready for review June 23, 2021 12:55
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #26440 opened

  • Start Time: 2021-06-23T11:55:38.258+0000

  • Duration: 77 min 33 sec

  • Commit: 8a3f256

Test stats 🧪

Test Results
Failed 0
Passed 1969
Skipped 192
Total 2161

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 1969
Skipped 192
Total 2161

@mdelapenya
Copy link
Contributor Author

mdelapenya commented Jun 24, 2021 •
edited
Loading

@jsoriano what I'm concerned about is why the existing tests did not catch this? I simply ran make system-tests in the x-pack/metricbeat dir and show the error because the image was not there.

@jsoriano
Copy link
Member

what I'm concerned about is why the existing tests did not catch this?

Yes, this is concerning, could this indicate that there are tests that are not being executed in CI?

@mdelapenya
Copy link
Contributor Author

@jsoriano, as you are more familiar with the maintenance branches, could you please add the required backport labels for mergify to perform the backports? 🙏

@mdelapenya mdelapenya merged commit 1ce38f4 into elastic:master Jun 24, 2021
@jsoriano jsoriano added backport-v7.13.0 Automated backport with mergify backport-v7.14.0 Automated backport with mergify labels Jun 24, 2021
@jsoriano jsoriano mentioned this pull request Jun 24, 2021
Closed
@jsoriano
Copy link
Member

what I'm concerned about is why the existing tests did not catch this?

Yes, this is concerning, could this indicate that there are tests that are not being executed in CI?

I have opened a PR that should trigger the mssql tests and doesn't include this fix, so it should fail 🤞 #26483

mergify bot pushed a commit that referenced this pull request Jun 24, 2021
@mdelapenya
fix: update MSSQL Server linux image's Docker registry (#26440)
ed2c150 
* chore: add supported versions for mssql

* fix: update repository for MS SQL Server linux image

(cherry picked from commit 1ce38f4)
@mergify mergify bot mentioned this pull request Jun 24, 2021
Merged
mergify bot pushed a commit that referenced this pull request Jun 24, 2021
@mdelapenya
fix: update MSSQL Server linux image's Docker registry (#26440)
70e1803 
* chore: add supported versions for mssql

* fix: update repository for MS SQL Server linux image

(cherry picked from commit 1ce38f4)
@mergify mergify bot mentioned this pull request Jun 24, 2021
Merged
mdelapenya added a commit to mdelapenya/beats that referenced this pull request Jun 28, 2021
@mdelapenya
Merge branch 'master' into archive-system-tests
b6dbec3 
* master: (32 commits)
  [Metricbeat] Change Account ID to Project ID in `gcp.billing` module (elastic#26412)
  update libbeat fields.ecs.yml file and ecsVersion to 1.10.0 (elastic#26121)
  [Filebeat] Update AWS ELB ingest pipeline (elastic#26441)
  [FIlebeat] add strict_date_optional_time_nanos date format to PanOS module (elastic#26158)
  Fix the irregular and typo on prometheus module. (elastic#25726)
  [Filebeat] Parse additonal debug data fields for Okta module (elastic#25818)
  fix: update MSSQL Server linux image's Docker registry (elastic#26440)
  Update indexing.go godocs (elastic#26408)
  Do not close filestream harvester if an unexpected error is returned when close.on_state_change.* is enabled (elastic#26411)
  Add support for copytruncate method when rotating input logs with an external tool in `filestream` input (elastic#23457)
  Allow fields with ip_range datatype (elastic#26444)
  Add Anomali ThreatStream support to threatintel module (elastic#26350)
  fix: use the right param type (elastic#26469)
  [Automation] Update elastic stack version to 8.0.0-7640093f for testing (elastic#26460)
  Set SM Filebeat modules as GA (elastic#26226)
  Fix rfc5464 date parsing in the syslog input (elastic#26419)
  Add linked account information into billing metricset (elastic#26285)
  [Filebeat] Update HA Proxy log grok patterns (elastic#25835)
  disable metricbeat logstash test_node_stats (elastic#26436)
  chore: pass BEAT_VERSION when running E2E tests (elastic#26291)
  ...
@mdelapenya mdelapenya mentioned this pull request Jun 29, 2021
Merged
8 tasks
v1v pushed a commit that referenced this pull request Jun 29, 2021
@mergify
fix: update MSSQL Server linux image's Docker registry (#26440) (#26485)
50ff1fc
v1v pushed a commit that referenced this pull request Jun 29, 2021
@mergify
fix: update MSSQL Server linux image's Docker registry (#26440) (#26486)
0f05ad5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuisathaverat kuisathaverat kuisathaverat approved these changes

@v1v v1v v1v approved these changes

@cachedout cachedout cachedout approved these changes

@jsoriano jsoriano jsoriano approved these changes

Assignees

@mdelapenya mdelapenya

Labels
backport-v7.13.0 Automated backport with mergify backport-v7.14.0 Automated backport with mergify Team:Automation Label for the Observability productivity team Team:Integrations Label for the Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Integrations] MSSQL server image is outdated
6 participants
@mdelapenya @elasticmachine @jsoriano @cachedout @v1v @kuisathaverat