[Elastic Agent] Await execution finish on windows #27730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalpristas
added
bug
Team:Elastic-Agent
|
Pinging @elastic/agent (Team:Agent) |
botelastic
bot
added
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
mergify bot
pushed a commit
that referenced
this pull request
Sep 3, 2021
* Await execution finish on windows * don't wait if not running as a service (cherry picked from commit 2f897aa)
mergify bot
pushed a commit
that referenced
this pull request
Sep 3, 2021
* Await execution finish on windows * don't wait if not running as a service (cherry picked from commit 2f897aa)
michalpristas
added a commit
that referenced
this pull request
Sep 6, 2021
michalpristas
added a commit
that referenced
this pull request
Sep 6, 2021
|
We attempted to validate above PR on 7.15.0-snapshot on windows 10 machine and found it fixed now.
Build details: Screenshot: Thanks |
Icedroid
pushed a commit
to Icedroid/beats
that referenced
this pull request
Nov 1, 2021
* Await execution finish on windows * don't wait if not running as a service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The problem is described in issue: #27527
When user wants to stop the service using service manager, error is returned about unexpected termination and agent is restarted.
Reason for this is that agent won't send
stoppedstate to service manager before termination.In our codebase we use
NotifyTerminationprovided by libbeat on exit. This closes channel and exits the state loop running in a separate goroutine which then should send thestoppedstate to service manager.The problem is when we exit right after this call and too quickly. In this case goroutine wont reach the point where
stoppedis sent and service manager gets the impression we crashed.To fix this we just need to make sure that
svc.Runinlibbeat/service/service_windows.gois finished before exiting. Usually it just takes few milliseconds to finish the process but 500 millisecond limit is there to prevent process getting stuck in case something goes wrong.Why is it important?
Fixes: #27527
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.