Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Beat generators #28816

Merged
merged 8 commits into from
Nov 5, 2021
Merged

Remove Beat generators #28816

merged 8 commits into from
Nov 5, 2021

Conversation

kvch
Copy link
Contributor

@kvch kvch commented Nov 4, 2021 •
edited
Loading

What does this PR do?

This PR removes Beat generators.

Why is it important?

From 8.0.0, we no longer support building custom Beats. This removes the documentation and the code as well.

If someone wants to build their custom Beats, they still can based on 7.16.

Checklist

  • My code follows the style guidelines of this project
    - [ ] I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
    - [ ] I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

Closes #28427

@kvch kvch requested review from jsoriano and ruflin November 4, 2021 16:34
@kvch kvch requested review from a team as code owners November 4, 2021 16:34
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Nov 4, 2021
@mergify
Copy link
Contributor

mergify bot commented Nov 4, 2021

This pull request does not have a backport label. Could you fix it @kvch? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@kvch kvch added the backport-v8.0.0 Automated backport with mergify label Nov 4, 2021
@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Nov 4, 2021
@kvch kvch added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Nov 4, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Nov 4, 2021
@mergify mergify bot removed the backport-skip Skip notification from the automated backport with mergify label Nov 4, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Nov 4, 2021 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-11-05T12:20:51.817+0000

  • Duration: 159 min 7 sec

  • Commit: 841bf44

Test stats 🧪

Test Results
Failed 0
Passed 54120
Skipped 5354
Total 59474

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

@mergify
Copy link
Contributor

mergify bot commented Nov 4, 2021

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b remove-generator-custom-beat upstream/remove-generator-custom-beat
git merge upstream/master
git push upstream remove-generator-custom-beat

ruflin
ruflin approved these changes Nov 5, 2021
View reviewed changes
Copy link
Member

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think it is important to note that custom beats can still be created with the generator from 7.x branch as this will work with 8.x

jsoriano
jsoriano reviewed Nov 5, 2021
View reviewed changes
Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Added a comment about keeping the documentation for new metricsets in Metricbeat.

Failure in docs build seems related.

dev-tools/mage/fmt.go Show resolved Hide resolved
docs/devguide/create-metricset.asciidoc
@@ -1,319 +0,0 @@
[[creating-metricsets]]
=== Creating a Metricset
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is developer documentation for Metricbeat. I think we should keep this, new metricsets may still be needed to act as new metric inputs.

docs/devguide/metricbeat-devguide.asciidoc Show resolved Hide resolved
generator/common/Makefile Show resolved Hide resolved
jsoriano
jsoriano approved these changes Nov 5, 2021
View reviewed changes
Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but there is still some missing reference affecting docs build.

@kvch kvch merged commit c0f42bd into elastic:master Nov 5, 2021
mergify bot pushed a commit that referenced this pull request Nov 5, 2021
@kvch
Remove Beat generators (#28816)
8373666 
From 8.0.0, we no longer support building custom Beats. This removes the documentation and the code as well.

If someone wants to build their custom Beats, they still can based on 7.16.

(cherry picked from commit c0f42bd)
@mergify mergify bot mentioned this pull request Nov 5, 2021
Merged
v1v added a commit to v1v/beats that referenced this pull request Nov 8, 2021
@v1v
Merge remote-tracking branch 'upstream/master' into feature/use-arch-…
3afea6c 
…in-the-package-binareis

* upstream/master:
  allows disable pod events enrichment with deployment name (elastic#28521)
  Remove Docker input from Filebeat (elastic#28817)
  [breaking] Make default_field: false the default for all fields (elastic#28596)
  Osquerybeat: Improve osquery client connect code (elastic#28848)
  Add crawler  metrics into the stats metricset for Enterprise Search (elastic#28790)
  Remove the now deprecated appsearch module from metricbeat (elastic#28850)
  Remove Beat generators (elastic#28816)
  chore: upload files to Google Storage when they exist (elastic#28836)
  Revert "chore(ci): disable E2E tests in Beats (elastic#28715)" (elastic#28812)
  Deprecate generating custom Beats (elastic#28814)
  [Metricbeat] upgrade flatbuffers to 1.12.1 (elastic#28094)
  Osquerybeat: Fix restart flags after previously bad config (elastic#28827)
  Force ECS and JSON logging for libbeat/logp (elastic#28573)
  Filebeat: Error on startup for unconfigured module (elastic#28818)
  Deprecate log input in favour of filestream (elastic#28623)
  Fix some spelling mistakes (elastic#28080)
@dedemorton dedemorton mentioned this pull request Nov 8, 2021
Merged
3 tasks
kvch added a commit that referenced this pull request Nov 9, 2021
@mergify @kvch
Remove Beat generators (#28816) (#28849)
74c134b 
From 8.0.0, we no longer support building custom Beats. This removes the documentation and the code as well.

If someone wants to build their custom Beats, they still can based on 7.16.

(cherry picked from commit c0f42bd)

Co-authored-by: Noémi Ványi <kvch@users.noreply.github.com>
@amirbenun amirbenun mentioned this pull request Dec 29, 2022
Closed
2 tasks
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@v1v
Merge remote-tracking branch 'upstream/master' into feature/use-arch-…
061692b 
…in-the-package-binareis

* upstream/master:
  allows disable pod events enrichment with deployment name (elastic#28521)
  Remove Docker input from Filebeat (elastic#28817)
  [breaking] Make default_field: false the default for all fields (elastic#28596)
  Osquerybeat: Improve osquery client connect code (elastic#28848)
  Add crawler  metrics into the stats metricset for Enterprise Search (elastic#28790)
  Remove the now deprecated appsearch module from metricbeat (elastic#28850)
  Remove Beat generators (elastic#28816)
  chore: upload files to Google Storage when they exist (elastic#28836)
  Revert "chore(ci): disable E2E tests in Beats (elastic#28715)" (elastic#28812)
  Deprecate generating custom Beats (elastic#28814)
  [Metricbeat] upgrade flatbuffers to 1.12.1 (elastic#28094)
  Osquerybeat: Fix restart flags after previously bad config (elastic#28827)
  Force ECS and JSON logging for libbeat/logp (elastic#28573)
  Filebeat: Error on startup for unconfigured module (elastic#28818)
  Deprecate log input in favour of filestream (elastic#28623)
  Fix some spelling mistakes (elastic#28080)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsoriano jsoriano jsoriano approved these changes

@ruflin ruflin ruflin approved these changes

Assignees
No one assigned
Labels
backport-v8.0.0 Automated backport with mergify Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom beats generator removal
4 participants
@kvch @elasticmachine @jsoriano @ruflin