Metricbeat system module updates for Windows #2884
Conversation
andrewkroh
added
bug
Metricbeat
andrewkroh
force-pushed
the
feature/update-gosigar
branch
3 times, most recently
from
9147dac to
ad04204
Compare
|
I would like to have elastic/gosigar#58 and #2282 (Metricbeat AppVeyor) merged first. Then I will update this PR with those fixes. |
|
@andrewkroh Both PR's were merged. |
| @@ -8,3 +8,4 @@ This metricset is available on: | |||
| - FreeBSD | |||
| - Linux | |||
| - OpenBSD | |||
| - Windows | |||
| @@ -1,58 +0,0 @@ | |||
| ########################## Metricbeat Configuration ########################### | |||
There was a problem hiding this comment.
Yeah, this is on purpose, but I did want to ask you about it. I removed this file. Where is this file used?
| @@ -17,10 +17,10 @@ metricbeat.modules: | |||
| - cpu | |||
|
|
|||
| # System Load stats | |||
| - load | |||
| #- load | |||
There was a problem hiding this comment.
Should we mention that we changed the defaults in the config file? Why is load disabled now by default?
| @@ -16,7 +16,7 @@ | |||
| - filesystem | |||
|
|
|||
| # File system summary stats | |||
| #- fsstat | |||
| - fsstat | |||
There was a problem hiding this comment.
Just making sure. We had this disabled before because it wasn't working on Windows and now it is?
There was a problem hiding this comment.
It was working on Windows previously. So maybe it was commented out to reduce the amount of data Metricbeat sends? But the fsstats data is used on the Metricbeat overview dashboard which is why I think we should enabled it by default.
| @@ -4,10 +4,10 @@ | |||
| - cpu | |||
|
|
|||
| # System Load stats | |||
| - load | |||
| #- load | |||
There was a problem hiding this comment.
I think we can leave this enabled. We have code to disable it automatically on WIndows: https://github.com/elastic/beats/blob/master/metricbeat/Makefile#L61
There was a problem hiding this comment.
Yeah, I'll revert this. For some reason I thought we removed all of the OS specific before-build changes.
|
|
||
| # Per CPU core stats | ||
| #- core | ||
| - core |
There was a problem hiding this comment.
Also not sure about this one, I think we had it disabled by default in an effort to keep disk usage down?
There was a problem hiding this comment.
I can revert this too. I was thinking that it was only commented out because of it not working on Windows.
andrewkroh
force-pushed
the
feature/update-gosigar
branch
2 times, most recently
from
3b59ad4 to
a1308f9
Compare
|
I updated the PR to contain the gosigar fixes and rebased it so that it gets built on AppVeyor. I reverted the changes to |
…6bc8887f99 This will fix issues with WMI queries on Windows XP and 2003. Fixes elastic#2885
- Added system core metricset for Windows. Per core metrics were implemented in elastic/gosigar. - Added logging of process/system details on Windows to aid in debugging (user, arch, cores, sid, privs). - Fixes elastic#2860 (PPID is zero on Windows). - Fixes elastic#1704 (Server 2003 - PID’s not recognized). The command line arguments for the process will not be reported on XP and 2003. - Fixes elastic#1897 (OpenProcess access denied on Windows). Added code to enable the SeDebugPrivilege when it is available. - Fixes elastic#2885 (diskio metricset fails on XP and 2003). - Enabled fsstats by default in Metricbeat config.
andrewkroh
force-pushed
the
feature/update-gosigar
branch
from
a1308f9 to
eb88c2c
Compare
andrewkroh
removed
the
needs_backport
in elastic/gosigar.
arch, cores, sid, privs).
for the process will not be reported on XP and 2003.
SeDebugPrivilege when it is available.