-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dissect trim panics from DELETE (\u007f) character #30658
Conversation
💚 CLA has been signed |
This pull request does not have a backport label. Could you fix it @montaguethomas? 🙏
NOTE: |
Seems I do not have permissions to set labels on the PR. Suggest this should be backported. |
This pull request is now in conflicts. Could you fix it? 🙏
|
This pull request is now in conflicts. Could you fix it? 🙏
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
/test |
@adriansr you were the original author here, can you review this fix? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for fixing. I'm adding some corrections to the changelog
This pull request is now in conflicts. Could you fix it? 🙏
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
@adriansr could we please merge it as it has been approved? |
Fixes an index out of range panic with asciiTrimmer.Trim(). Closes elastic#30657
…007f) character (elastic#30867) Fixes an index out of range panic with asciiTrimmer.Trim(). Closes elastic#30657 (cherry picked from commit 70298dd) Co-authored-by: Thomas Montague <montague.thomas@gmail.com>
Fixes an index out of range panic with asciiTrimmer.Trim(). Closes #30657
What does this PR do?
Fixes an index out of range panic with
asciiTrimmer.Trim()
.Why is it important?
Should a string begin or end with the DELETE (\u007f)(127) ASCII character (with or without a leading/trailing space),
asciiTrimmer.Trim()
will throw a panic.Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration filesCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.How to test this PR locally
Run the updated tests without the fix in trim.go.
Related issues
Logs