Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: split windows in mandatory and ext_win stages #30781

Merged
merged 5 commits into from
Mar 15, 2022
Merged

ci: split windows in mandatory and ext_win stages #30781

merged 5 commits into from
Mar 15, 2022

Conversation

v1v
Copy link
Member

@v1v v1v commented Mar 11, 2022 •
edited
Loading

What does this PR do?

Split the Windows OS build/test stages in two meta-stages:

  • Mandatory for windows-2022 and windows-2016. This is mandatory for all the builds in the CI (PRs, branches, tags)
  • Extended support for other windows versions. This is only available for branches or UI interactions with the parameter runAllStages)

Windows-2019 is not anymore the default OS but windows-2022 and windows-2016

Removed tag event builds, every commit in this project is validated in the CI, so there is no need to run a build for tags.

Move the arm stages to mandatory.

Mandatory stages run always. But extended support for other windows versions only run for branches.

Why is it important?

Faster builds on a PR basis since the extended meta-stage has been simplified a bit by moving some stages to the mandatory meta-stage or the new extended-win meta-stage.

In other words, the existing meta-stages were:

checkout - lint - mandatory - extended - package

and now:

checkout - lint - mandatory - extended - extended-win - package

and each meta-stage runs in parallel a set of stages.

Questions

  • Is it required to run on Windows for each Beat? Or are there any Beats that are not windows supported? If so which should be disabled?

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Mar 11, 2022
@mergify mergify bot assigned v1v Mar 11, 2022
@mergify
Copy link
Contributor

mergify bot commented Mar 11, 2022

This pull request does not have a backport label. Could you fix it @v1v? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Mar 11, 2022
@v1v v1v added backport-v8.1.0 Automated backport with mergify backport-v8.2.0 Automated backport with mergify backport-7.17 Automated backport to the 7.17 branch with mergify labels Mar 11, 2022
@mergify mergify bot removed the backport-skip Skip notification from the automated backport with mergify label Mar 11, 2022
@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 11, 2022 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-03-14T19:03:59.282+0000

  • Duration: 112 min 8 sec

Test stats 🧪

Test Results
Failed 0
Passed 264
Skipped 42
Total 306

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@v1v v1v requested review from cmacknz, ph, jlind23 and a team March 14, 2022 11:37
@v1v v1v marked this pull request as ready for review March 14, 2022 11:38
@v1v v1v requested review from a team as code owners March 14, 2022 11:38
@ph
Copy link
Contributor

ph commented Mar 14, 2022

Is it required to run on Windows for each Beat? Or are there any Beats that are not windows supported? If so which should be disabled?

I would say dockerlogbeat which isn't Windows, I don't know exactly the states or what test is run for that component.
Everything else need windows testing.

ph
ph approved these changes Mar 14, 2022
View reviewed changes
Copy link
Contributor

@ph ph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not completely familiar with everything Jenkins pipeline related,
I've looked at the current ci job run for this PR and the changes in the YML and they do appear fine to me. Let's have more eye on this.

@botelastic botelastic bot added Team:Automation Label for the Observability productivity team and removed needs_team Indicates that the issue/PR needs a Team:* label labels Mar 14, 2022
cachedout
cachedout reviewed Mar 14, 2022
View reviewed changes
x-pack/auditbeat/Jenkinsfile.yml Outdated Show resolved Hide resolved
x-pack/filebeat/Jenkinsfile.yml Show resolved Hide resolved
@cmacknz cmacknz mentioned this pull request Mar 14, 2022
Closed
@v1v
Copy link
Member Author

v1v commented Mar 14, 2022

/test

@v1v v1v merged commit f0912da into elastic:main Mar 15, 2022
mergify bot pushed a commit that referenced this pull request Mar 15, 2022
@v1v
ci: split windows in mandatory and ext_win stages (#30781)
b879ed3 
(cherry picked from commit f0912da)

# Conflicts:
#	auditbeat/Jenkinsfile.yml
#	filebeat/Jenkinsfile.yml
#	heartbeat/Jenkinsfile.yml
#	metricbeat/Jenkinsfile.yml
#	packetbeat/Jenkinsfile.yml
#	winlogbeat/Jenkinsfile.yml
#	x-pack/auditbeat/Jenkinsfile.yml
#	x-pack/elastic-agent/Jenkinsfile.yml
#	x-pack/filebeat/Jenkinsfile.yml
#	x-pack/functionbeat/Jenkinsfile.yml
#	x-pack/heartbeat/Jenkinsfile.yml
#	x-pack/metricbeat/Jenkinsfile.yml
#	x-pack/osquerybeat/Jenkinsfile.yml
#	x-pack/packetbeat/Jenkinsfile.yml
#	x-pack/winlogbeat/Jenkinsfile.yml
@mergify mergify bot mentioned this pull request Mar 15, 2022
Merged
mergify bot pushed a commit that referenced this pull request Mar 15, 2022
@v1v
ci: split windows in mandatory and ext_win stages (#30781)
9021823 
(cherry picked from commit f0912da)
@mergify mergify bot mentioned this pull request Mar 15, 2022
Merged
v1v pushed a commit that referenced this pull request Mar 15, 2022
@mergify
ci: split windows in mandatory and ext_win stages (#30781) (#30824)
56a8dae
@v1v
Copy link
Member Author

v1v commented Mar 16, 2022

@Mergifyio backport 7.17

@mergify
Copy link
Contributor

mergify bot commented Mar 16, 2022

backport 7.17

✅ Backports have been created

v1v pushed a commit that referenced this pull request Mar 17, 2022
@mergify
[7.17](backport #30781) ci: split windows in mandatory and ext_win st…
2645bbe 
…ages (#30823)
kush-elastic pushed a commit to kush-elastic/beats that referenced this pull request May 2, 2022
@v1v @kush-elastic
ci: split windows in mandatory and ext_win stages (elastic#30781)
3a834d0
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
@v1v @chrisberkhout
ci: split windows in mandatory and ext_win stages (#30781)
7456746
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cachedout cachedout cachedout left review comments

@cmacknz cmacknz cmacknz approved these changes

@ph ph ph approved these changes

@jlind23 jlind23 Awaiting requested review from jlind23

Assignees

@v1v v1v

Labels
backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.1.0 Automated backport with mergify backport-v8.2.0 Automated backport with mergify Team:Automation Label for the Observability productivity team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@v1v @elasticmachine @ph @cachedout @cmacknz