Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add field kubernetes.volume.fs.inodes.pct #30785

Merged
merged 1 commit into from
Mar 17, 2022
Merged

Add field kubernetes.volume.fs.inodes.pct #30785

merged 1 commit into from
Mar 17, 2022

Conversation

JulienOrain
Copy link
Contributor

@JulienOrain JulienOrain commented Mar 11, 2022 •
edited
Loading

  • Enhancement

What does this PR do?

This PR adds kubernetes.volume.fs.inodes.pct field.

This field is calculated as kubernetes.volume.fs.inodes.used / kubernetes.volume.fs.inodes.count

Why is it important?

Provide used inodes insight with a direct metric.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Run the testsuite

Related issues

Use cases

NA

Screenshots

NA

Logs

NA

@cla-checker-service
Copy link

cla-checker-service bot commented Mar 11, 2022 •
edited
Loading

💚 CLA has been signed

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Mar 11, 2022
@mergify
Copy link
Contributor

mergify bot commented Mar 11, 2022

This pull request does not have a backport label. Could you fix it @JulienOrain? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Mar 11, 2022
@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 11, 2022 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-03-16T18:30:54.785+0000

  • Duration: 10 min 48 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@JulienOrain
Copy link
Contributor Author

/test

@jsoriano jsoriano requested a review from a team March 15, 2022 17:21
@jsoriano jsoriano added the Team:Integrations Label for the Integrations team label Mar 15, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Mar 15, 2022
@tetianakravchenko
Copy link
Contributor

Hi @JulienOrain, thank you for your contribution, could you please sign CLA?

@JulienOrain
Copy link
Contributor Author

Hello @tetianakravchenko

Thanks for your review.

CLA is now signed.

Have a nice week ;-)

MichaelKatsoulis
MichaelKatsoulis approved these changes Mar 16, 2022
View reviewed changes
Copy link
Contributor

@MichaelKatsoulis MichaelKatsoulis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JulienOrain . Just a small update!

@MichaelKatsoulis MichaelKatsoulis added backport-v8.2.0 Automated backport with mergify Team:Cloudnative-Monitoring Label for the Cloud Native Monitoring team labels Mar 16, 2022
@mergify mergify bot removed the backport-skip Skip notification from the automated backport with mergify label Mar 16, 2022
@MichaelKatsoulis MichaelKatsoulis added backport-skip Skip notification from the automated backport with mergify and removed Team:Integrations Label for the Integrations team labels Mar 16, 2022
@mergify mergify bot removed the backport-skip Skip notification from the automated backport with mergify label Mar 16, 2022
@JulienOrain
Copy link
Contributor Author

Hello @MichaelKatsoulis
Thanks for your review.
I applied your suggestion.
Have a nice week !

@mergify
Copy link
Contributor

mergify bot commented Mar 16, 2022

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b inodes upstream/inodes
git merge upstream/main
git push upstream inodes

tetianakravchenko
tetianakravchenko reviewed Mar 16, 2022
View reviewed changes
CHANGELOG-developer.next.asciidoc Outdated
@@ -134,6 +134,7 @@ The list below covers the major changes between 7.0.0-rc2 and main only.
- Add gcp firestore metricset. {pull}29918[29918]
- Added TESTING_FILEBEAT_FILEPATTERN option for filebeat module pytests {pull}30103[30103]
- Add gcp dataproc metricset. {pull}30008[30008]
- Add kubernetes.volume.fs.inodes.pct field.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be moved to https://github.com/elastic/beats/blob/main/CHANGELOG.next.asciidoc, under Added > Metricbeat

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done ;-)

@tetianakravchenko
Copy link
Contributor

@JulienOrain could you please resolve conflict and check my comment above - #30785 (comment) ?

@JulienOrain
Copy link
Contributor Author

@tetianakravchenko done ✔️

@tetianakravchenko
Copy link
Contributor

/test

1 similar comment
@jsoriano
Copy link
Member

/test

@tetianakravchenko tetianakravchenko merged commit 083142d into elastic:main Mar 17, 2022
@JulienOrain
Copy link
Contributor Author

Cool, thanks for my first elastic PR ;-) !!

@ChrsMark ChrsMark mentioned this pull request Mar 30, 2022
Closed
kush-elastic pushed a commit to kush-elastic/beats that referenced this pull request May 2, 2022
@JulienOrain @kush-elastic
Add field kubernetes.volume.fs.inodes.pct (elastic#30785)
c0568ec
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
@JulienOrain @chrisberkhout
Add field kubernetes.volume.fs.inodes.pct (#30785)
b652df9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tetianakravchenko tetianakravchenko tetianakravchenko approved these changes

@MichaelKatsoulis MichaelKatsoulis MichaelKatsoulis approved these changes

@ChrsMark ChrsMark Awaiting requested review from ChrsMark

Assignees

@JulienOrain JulienOrain

Labels
backport-v8.2.0 Automated backport with mergify Team:Cloudnative-Monitoring Label for the Cloud Native Monitoring team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add field kubernetes.volume.fs.inodes.pct to get used inodes percent
5 participants
@JulienOrain @elasticmachine @tetianakravchenko @jsoriano @MichaelKatsoulis