Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.17](backport #30155) [winlogbeat] Retry EvtSubscribe from start if fails with strict mode #31042

Merged
merged 3 commits into from
Apr 20, 2022
Merged

[7.17](backport #30155) [winlogbeat] Retry EvtSubscribe from start if fails with strict mode #31042

merged 3 commits into from
Apr 20, 2022

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Mar 29, 2022 •
edited by zube bot
Loading

This is an automatic backport of pull request #30155 done by Mergify.

Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@marc-gr
[winlogbeat] Retry EvtSubscribe from start if fails with strict mode (#…
719e210 
…30155)

* Retry EvtSubscribe from start if fails with strict mode

* Add metrics and tests

* Shorten test name

* Fix debug message

* Update winlogbeat/beater/winlogbeat.go

Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>

* Shorten test names

* Add changelog

* Shorten bad bookmark test

* Close file on test

* restructure test

* Fix fake bookmark generation in test

One of the format strings was ignored, resulting in invalid YaML

* Additional logging

* Fix linting issues

* Fix linting issue

* Remove test output

* Fix usage of fmt.Errorf

Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
Co-authored-by: Adrian Serrano <adrisr83@gmail.com>
(cherry picked from commit e8a4675)
@mergify mergify bot added the backport label Mar 29, 2022
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Mar 29, 2022
@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 29, 2022 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-04-20T09:51:15.295+0000

  • Duration: 80 min 47 sec

Test stats 🧪

Test Results
Failed 0
Passed 19869
Skipped 1542
Total 21411

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@efd6 efd6 mentioned this pull request Mar 31, 2022
Merged
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Apr 1, 2022
@mergify
Copy link
Contributor Author

mergify bot commented Apr 4, 2022

This pull request has not been merged yet. Could you please review and merge it @marc-gr? 🙏

@andrewkroh
Copy link
Member

/test

@andrewkroh
Copy link
Member

Is this dependent upon another backport? The python tests are failing looking for

>       os.unlink(os.path.join(self.working_dir, "output", self.beat_name + "-" + self.today + ".ndjson"))
E       AttributeError: 'Test' object has no attribute 'today'

@mergify
Copy link
Contributor Author

mergify bot commented Apr 11, 2022

This pull request has not been merged yet. Could you please review and merge it @marc-gr? 🙏

1 similar comment
@mergify
Copy link
Contributor Author

mergify bot commented Apr 18, 2022

This pull request has not been merged yet. Could you please review and merge it @marc-gr? 🙏

@mergify mergify bot requested review from a team as code owners April 20, 2022 09:50
@mergify mergify bot requested review from belimawr and faec and removed request for a team April 20, 2022 09:50
@marc-gr marc-gr merged commit 995c0a7 into 7.17 Apr 20, 2022
@marc-gr marc-gr deleted the mergify/bp/7.17/pr-30155 branch April 20, 2022 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@belimawr belimawr Awaiting requested review from belimawr belimawr was automatically assigned from elastic/elastic-agent-data-plane

@faec faec Awaiting requested review from faec faec was automatically assigned from elastic/elastic-agent-data-plane

Assignees

@marc-gr marc-gr

Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@elasticmachine @andrewkroh @marc-gr @jlind23