Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use mapstr.M instead of common.MapStr #31420

Merged
merged 7 commits into from
Apr 28, 2022
Merged

Conversation

kvch
Copy link
Contributor

@kvch kvch commented Apr 26, 2022

What does this PR do?

This PR adopts mapstr.M and gets rid of common.MapStr from libbeat.

Why is it important?

We are removing common parts from libbeat in favour of elastic-agent-libs.

Checklist

  • My code follows the style guidelines of this project
    - [ ] I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
    - [ ] I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@kvch kvch requested a review from a team as a code owner April 26, 2022 15:04
@kvch kvch requested a review from a team April 26, 2022 15:04
@kvch kvch requested review from a team as code owners April 26, 2022 15:04
@kvch kvch requested review from rdner and fearful-symmetry and removed request for a team April 26, 2022 15:04
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Apr 26, 2022
@mergify mergify bot assigned kvch Apr 26, 2022
@elasticmachine
Copy link
Collaborator

elasticmachine commented Apr 26, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-04-28T09:46:44.531+0000

  • Duration: 142 min 31 sec

Test stats 🧪

Test Results
Failed 0
Passed 24634
Skipped 2142
Total 26776

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@rdner
Copy link
Member

rdner commented Apr 26, 2022

There are some failures on the CI (not linting-related).

Screenshot 2022-04-26 at 17 51 16

@rdner
Copy link
Member

rdner commented Apr 27, 2022

It's not over yet :)

Screenshot 2022-04-27 at 09 16 19

@kvch
Copy link
Contributor Author

kvch commented Apr 27, 2022

To decrease the amount of changes, the documentation fixes will come in a new PR.

@rdner rdner mentioned this pull request Apr 27, 2022
5 tasks
@mergify
Copy link
Contributor

mergify bot commented Apr 27, 2022

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b use-mapstr-from-libs upstream/use-mapstr-from-libs
git merge upstream/main
git push upstream use-mapstr-from-libs

@kvch
Copy link
Contributor Author

kvch commented Apr 28, 2022

/test

@kvch kvch merged commit 89bcc33 into elastic:main Apr 28, 2022
kush-elastic pushed a commit to kush-elastic/beats that referenced this pull request May 2, 2022
@joshdover joshdover added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Aug 2, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Aug 2, 2022
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants