rename queue.Batch.ACK -> queue.Batch.Done #31903
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Rename the
ACK
function in thequeue.Batch
interface toDone
. This function is the only way to finish handling a batch, and must be called regardless of whether the events were acked or not. Its only effect is to inform the queue that the events can be discarded (and to trigger any associated callbacks).queue.Batch.ACK
is used in the vicinity of actual ACK handling, which can make it confusing to follow the side effects of various similarly-named functions.Done
more clearly separates ACK handling from general event cleanup.Checklist
I have made corresponding changes to the documentationI have made corresponding change to the default configuration filesI have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.