Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Beats to elastic-agent-libs v0.2.7 #32161

Merged
merged 6 commits into from
Jul 5, 2022

Conversation

cmacknz
Copy link
Member

@cmacknz cmacknz commented Jun 29, 2022

The changes this picks up per https://github.com/elastic/elastic-agent-libs/releases are:

  1. Remove empty string as default value for VerificationMode  elastic-agent-libs#59
  2. Modify npipe to directly get the user SID elastic-agent-libs#62
  3. mapstr: optimyze Clone elastic-agent-libs#64

I don't think any of these are user facing so I haven't updated the changelog. Probably we should automate this update to happen once a week or so, but we'd always need to watch for changelog updates.

@cmacknz cmacknz added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Jun 29, 2022
@cmacknz cmacknz requested a review from a team as a code owner June 29, 2022 19:55
@cmacknz cmacknz self-assigned this Jun 29, 2022
@cmacknz cmacknz requested review from rdner and kvch and removed request for a team June 29, 2022 19:55
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 29, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jun 29, 2022
@cmacknz cmacknz changed the title Update to elastic-agent-libs v0.2.7 Update Beats to elastic-agent-libs v0.2.7 Jun 29, 2022
@cmacknz cmacknz requested review from narph and andrewkroh June 29, 2022 19:56
@cmacknz
Copy link
Member Author

cmacknz commented Jun 29, 2022

Authors of the changes being picked up added as reviewers.

@elasticmachine
Copy link
Collaborator

elasticmachine commented Jun 29, 2022

💔 Build Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-05T17:47:46.235+0000

  • Duration: 105 min 52 sec

Test stats 🧪

Test Results
Failed 0
Passed 22405
Skipped 1937
Total 24342

Steps errors 3

Expand to view the steps failures

Docker login
  • Took 0 min 7 sec . View more details here
  • Description: set +x if command -v host 2>&1 > /dev/null; then host docker.io 2>&1 > /dev/null fi if command -v dig 2>&1 > /dev/null; then dig docker.io 2>&1 > /dev/null fi docker login -u "${DOCKER_USER}" -p "${DOCKER_PASSWORD}" "docker.io" 2>/dev/null
x-pack/filebeat-goIntegTest - mage goIntegTest
  • Took 12 min 12 sec . View more details here
  • Description: mage goIntegTest
Building Beats » Beats Packaging » PR-32161
  • Took 28 min 2 sec . View more details here
  • Description: null

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@mergify
Copy link
Contributor

mergify bot commented Jun 30, 2022

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b update-elastic-agent-libs upstream/update-elastic-agent-libs
git merge upstream/main
git push upstream update-elastic-agent-libs

rdner
rdner previously approved these changes Jun 30, 2022
@rdner rdner dismissed their stale review June 30, 2022 07:15

All the test failures are legit, needs to be fixed before approval

@cmacknz
Copy link
Member Author

cmacknz commented Jul 5, 2022

/test

@cmacknz
Copy link
Member Author

cmacknz commented Jul 5, 2022

Packaging failures seem unrelated:


[2022-07-05T19:22:17.694Z] Status: Downloaded newer image for docker.elastic.co/beats-dev/golang-crossbuild:1.17.11-darwin-arm64-debian10

[2022-07-05T19:22:23.026Z] >> Building using: cmd='build/mage-linux-amd64 golangCrossBuild', env=[CC=oa64-clang, CXX=oa64-clang++, GOARCH=arm64, GOARM=, GOOS=darwin, PLATFORM_ID=darwin-arm64]

[2022-07-05T19:25:47.787Z] # github.com/elastic/beats/v7/metricbeat

[2022-07-05T19:25:47.787Z] /usr/local/go/pkg/tool/linux_amd64/link: /usr/local/go/pkg/tool/linux_amd64/link: running dsymutil failed: exit status 1

[2022-07-05T19:25:47.787Z] osxcross: error: xcrun: cannot find 'dsymutil' executable

@cmacknz
Copy link
Member Author

cmacknz commented Jul 5, 2022

/package

@cmacknz cmacknz merged commit 13e3214 into elastic:main Jul 5, 2022
@cmacknz cmacknz deleted the update-elastic-agent-libs branch July 5, 2022 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants