-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
action: checks for auditbeat and x-pack/auditbeat #32745
Conversation
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Query about versions of actions/checkout and actions/setup-go (both have a v3). LGTM if these are as desired.
use v3 and avoid latest in favour of go.sum
This reverts commit 134b7c6.
use v3 and avoid latest in favour of go.sum
This pull request is now in conflicts. Could you fix it? 🙏
|
(cherry picked from commit beff80f) # Conflicts: # .github/workflows/opentelemetry.yml # auditbeat/Jenkinsfile.yml # x-pack/auditbeat/Jenkinsfile.yml
(cherry picked from commit beff80f) # Conflicts: # .github/workflows/opentelemetry.yml
What does this PR do?
Use GitHub actions to run the
check stage
forauditbeat
andx-pack/auditbeat
What's the
check stage
?make check
make update
make check-no-changes
mage check
mage update
Why is it important?
Faster builds by running linting/checks outside of the main CI Pipeline.
Errors
librpm-dev
is required otherwise:Further details
The existing checks in Jenkins are replaced with GitHub checks, hence the union of these 2 new Github workflows substitutes each former check. Therefore, the same commands will run for the same scenarios.
Results
Nearly 10 minutes since they build was triggered in Jenkins and still waiting for workers to be assigned, while the new GitHub checks finished relatively much faster
Related issues
Similar to #32711