Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

action: checks for auditbeat and x-pack/auditbeat #32745

Merged
merged 10 commits into from
Aug 24, 2022

Conversation

v1v
Copy link
Member

@v1v v1v commented Aug 22, 2022

What does this PR do?

Use GitHub actions to run the check stage for auditbeat and x-pack/auditbeat

What's the check stage?

  • make check
  • make update
  • make check-no-changes
  • mage check
  • mage update

Why is it important?

Faster builds by running linting/checks outside of the main CI Pipeline.

Errors

librpm-dev is required otherwise:

Error: module/system/package/rpm_linux.go:26:10: fatal error: rpm/rpmlib.h: No such file or directory
   26 | #include <rpm/rpmlib.h>
      |          ^~~~~~~~~~~~~~
compilation terminated.
# github.com/elastic/beats/v7/x-pack/auditbeat/module/system/package
Error: module/system/package/rpm_linux.go:26:10: fatal error: rpm/rpmlib.h: No such file or directory
   26 | #include <rpm/rpmlib.h>
      |          ^~~~~~~~~~~~~~

Further details

The existing checks in Jenkins are replaced with GitHub checks, hence the union of these 2 new Github workflows substitutes each former check. Therefore, the same commands will run for the same scenarios.

Results

Nearly 10 minutes since they build was triggered in Jenkins and still waiting for workers to be assigned, while the new GitHub checks finished relatively much faster

Related issues

Similar to #32711

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Aug 22, 2022
@mergify mergify bot assigned v1v Aug 22, 2022
@mergify
Copy link
Contributor

mergify bot commented Aug 22, 2022

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @v1v? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@v1v v1v added automation Team:Automation Label for the Observability productivity team backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.4.0 Automated backport with mergify and removed needs_team Indicates that the issue/PR needs a Team:* label labels Aug 22, 2022
@elasticmachine
Copy link
Collaborator

elasticmachine commented Aug 22, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-08-24T14:46:26.224+0000

  • Duration: 43 min 52 sec

Test stats 🧪

Test Results
Failed 0
Passed 570
Skipped 81
Total 651

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@v1v v1v marked this pull request as ready for review August 22, 2022 15:11
@v1v v1v requested review from a team as code owners August 22, 2022 15:11
@v1v v1v requested review from fearful-symmetry, leehinman and a team and removed request for a team August 22, 2022 15:11
Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Query about versions of actions/checkout and actions/setup-go (both have a v3). LGTM if these are as desired.

use v3 and avoid latest in favour of go.sum
use v3 and avoid latest in favour of go.sum
@mergify
Copy link
Contributor

mergify bot commented Aug 24, 2022

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b feature/check-actions-other-modules upstream/feature/check-actions-other-modules
git merge upstream/main
git push upstream feature/check-actions-other-modules

@v1v v1v merged commit beff80f into elastic:main Aug 24, 2022
mergify bot pushed a commit that referenced this pull request Aug 24, 2022
(cherry picked from commit beff80f)

# Conflicts:
#	.github/workflows/opentelemetry.yml
#	auditbeat/Jenkinsfile.yml
#	x-pack/auditbeat/Jenkinsfile.yml
mergify bot pushed a commit that referenced this pull request Aug 24, 2022
(cherry picked from commit beff80f)

# Conflicts:
#	.github/workflows/opentelemetry.yml
v1v pushed a commit that referenced this pull request Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.4.0 Automated backport with mergify Team:Automation Label for the Observability productivity team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants