-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to disable pod events enrichment with deployment name #34097
Conversation
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Namespace: metaCfg, | ||
Node: metaCfg, | ||
Namespace: metaCfg, | ||
Deployment: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should not this be false?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prior to this, it works like "true" be default so we need to preserve it as is and just give the option to disable it when users actually need this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
just one documentation comment
Co-authored-by: Tetiana Kravchenko <tanya.kravchenko.v@gmail.com>
Kudos, SonarCloud Quality Gate passed!
|
What does this PR do?
This is a "backport" of #28521 so as to support disabling of Deployment metadata enrichment in Pod events.
This will allow us to disable the enrichment that in large clusters can cost a lot and push the k8s API server.
@gizas @tetianakravchenko what do you think?