Fix mongodb multiple hosts connection issue

CHANGELOG-developer.next.asciidoc

@@ -79,6 +79,7 @@ The list below covers the major changes between 7.0.0-rc2 and main only.
 - The beat.cgroup.memory.mem.usage.bytes metric is now a gauge {issue}31582[31582] {pull}32652[32652]
 - Fix the integration testcase docker port mapping for sql and oracle modules {pull}34221[34221]
 - Fix the ingest pipeline for mysql slowlog to parse schema name with dash {pull}34371[34372]
+- Fix the multiple host support for mongodb module {pull}34624[34624]
 
 ==== Added
 

metricbeat/docs/modules/mongodb.asciidoc

@@ -42,6 +42,27 @@ Or more complex like:
   hosts: ["mongodb://myuser:mypass@localhost:40001", "otherhost:40001"]
 ----------------------------------------------------------------------
 
+some more supported URLS are:
+
+[source,yaml]
+----------------------------------------------------------------------
+- module: mongodb
+  hosts: ["mongodb://localhost:27017,localhost:27022,localhost:27023"]
+----------------------------------------------------------------------
+
+[source,yaml]
+----------------------------------------------------------------------
+- module: mongodb
+  hosts: ["mongodb://localhost:27017/?directConnection=true"]
+----------------------------------------------------------------------
+
+[source,yaml]
+----------------------------------------------------------------------
+- module: mongodb
+  hosts: ["mongodb://localhost:27017,localhost:27022,localhost:27023/?replicaSet=dbrs"]
+----------------------------------------------------------------------
+
+
 The username and password can be included in the URL or they can be set using
 the respective configuration options. The credentials in the URL take precedence
 over the username and password configuration options.
@@ -60,8 +81,8 @@ The default metricsets are `collstats`, `dbstats` and `status`.
 [float]
 === Compatibility
 
-The MongoDB metricsets were tested with MongoDB 3.4 and 3.0 and are expected to
-work with all versions >= 2.8.
+The MongoDB metricsets were tested with MongoDB 5.0 and are expected to
+work with all versions >= 5.0.
 
 [float]
 === MongoDB Privileges

metricbeat/module/mongodb/_meta/docs.asciidoc

@@ -31,6 +31,27 @@ Or more complex like:
   hosts: ["mongodb://myuser:mypass@localhost:40001", "otherhost:40001"]
 ----------------------------------------------------------------------
 
+some more supported URLS are:
+
+[source,yaml]
+----------------------------------------------------------------------
+- module: mongodb
+  hosts: ["mongodb://localhost:27017,localhost:27022,localhost:27023"]
+----------------------------------------------------------------------
+
+[source,yaml]
+----------------------------------------------------------------------
+- module: mongodb
+  hosts: ["mongodb://localhost:27017/?directConnection=true"]
+----------------------------------------------------------------------
+
+[source,yaml]
+----------------------------------------------------------------------
+- module: mongodb
+  hosts: ["mongodb://localhost:27017,localhost:27022,localhost:27023/?replicaSet=dbrs"]
+----------------------------------------------------------------------
+
+
 The username and password can be included in the URL or they can be set using
 the respective configuration options. The credentials in the URL take precedence
 over the username and password configuration options.
@@ -49,8 +70,8 @@ The default metricsets are `collstats`, `dbstats` and `status`.
 [float]
 === Compatibility
 
-The MongoDB metricsets were tested with MongoDB 3.4 and 3.0 and are expected to
-work with all versions >= 2.8.
+The MongoDB metricsets were tested with MongoDB 5.0 and are expected to
+work with all versions >= 5.0.
 
 [float]
 === MongoDB Privileges

metricbeat/module/mongodb/dbstats/dbstats_integration_test.go

@@ -51,22 +51,24 @@ func TestFetch(t *testing.T) {
 		assert.True(t, collections > 0)
 
 		objects := metricsetFields["objects"].(int32)
-		assert.True(t, objects > 0)
+		assert.True(t, objects >= 0)
 
 		avgObjSize, err := metricsetFields.GetValue("avg_obj_size.bytes")
 		assert.NoError(t, err)
-		assert.True(t, avgObjSize.(float64) > 0)
+		assert.True(t, avgObjSize.(float64) >= 0)
 
 		dataSize, err := metricsetFields.GetValue("data_size.bytes")
 		assert.NoError(t, err)
-		assert.True(t, dataSize.(float64) > 0)
+		assert.True(t, dataSize.(float64) >= 0)
 
 		storageSize, err := metricsetFields.GetValue("storage_size.bytes")
 		assert.NoError(t, err)
-		assert.True(t, storageSize.(float64) > 0)
+		assert.True(t, storageSize.(float64) >= 0)
 
-		numExtents := metricsetFields["num_extents"].(int32)
-		assert.True(t, numExtents >= 0)
+		if metricsetFields["num_extents"] != nil {
+			numExtents := metricsetFields["num_extents"].(int32)
+			assert.True(t, numExtents >= 0)
+		}
 
 		indexes := metricsetFields["indexes"].(int32)
 		assert.True(t, indexes >= 0)

metricbeat/module/mongodb/docker-compose.yml

@@ -1,12 +1,11 @@
-version: "2.3"
+version: '2.3'
 
 services:
   mongodb:
-    image: docker.elastic.co/integrations-ci/beats-mongodb:${MONGODB_VERSION:-3.4}-1
+    image: docker.elastic.co/integrations-ci/beats-mongodb:${MONGODB_VERSION:-5.0}-1
     build:
       context: ./_meta
       args:
-        MONGODB_VERSION: "${MONGODB_VERSION:-3.4}"
-    command: mongod --replSet beats
+        MONGODB_VERSION: ${MONGODB_VERSION:-5.0}
     ports:
-      - 27017
+      - 27017:27017

metricbeat/module/mongodb/mongodb.go

@@ -123,7 +123,7 @@ func ParseURL(module mb.Module, host string) (mb.HostData, error) {
 		Username:                c.Username,
 		Password:                c.Password,
 	}
-	clientOptions.SetDirect(true)
+
 	clientOptions.ApplyURI(host)
 
 	// https://docs.mongodb.com/manual/reference/connection-string/
@@ -154,7 +154,6 @@ func NewClient(config ModuleConfig, timeout time.Duration, mode readpref.Mode) (
 			clientOptions.Auth.AuthMechanismProperties = config.Credentials.AuthMechanismProperties
 		}
 	}
-	clientOptions.SetHosts(config.Hosts)
 
 	if mode == 0 {
 		mode = readpref.NearestMode
@@ -165,7 +164,6 @@ func NewClient(config ModuleConfig, timeout time.Duration, mode readpref.Mode) (
 		return nil, err
 	}
 	clientOptions.SetReadPreference(readPreference)
-	clientOptions.SetDirect(true)
 	clientOptions.SetConnectTimeout(timeout)
 
 	if config.TLS.IsEnabled() {

metricbeat/module/mongodb/mongodb_test.go

@@ -95,6 +95,16 @@ func TestParseMongoURL(t *testing.T) {
 			ExpectedUsername: "",
 			ExpectedPassword: "",
 		},
+		{
+			Name:     "with options replicaset",
+			URL:      "mongodb://localhost:40001/?replicaSet=dbrs",
+			Username: "anotheruser",
+			Password: "anotherpass",
+
+			ExpectedAddr:     "localhost:40001",
+			ExpectedUsername: "anotheruser",
+			ExpectedPassword: "anotherpass",
+		},
 	}
 
 	for _, test := range tests {

metricbeat/module/mongodb/status/status_integration_test.go

@@ -31,7 +31,6 @@ import (
 
 func TestFetch(t *testing.T) {
 	service := compose.EnsureUp(t, "mongodb")
-
 	f := mbtest.NewReportingMetricSetV2Error(t, getConfig(service.Host()))
 	events, errs := mbtest.ReportingFetchV2Error(f)
 
@@ -53,7 +52,7 @@ func TestFetch(t *testing.T) {
 	assert.True(t, available.(int32) > 0)
 
 	pageFaults, _ := event.GetValue("mongodb.status.extra_info.page_faults")
-	assert.True(t, pageFaults.(int32) >= 0)
+	assert.True(t, pageFaults.(int64) >= 0)
 }
 
 func TestData(t *testing.T) {