-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Filebeat][CometD] Resolve flaky unit test #34903
[Filebeat][CometD] Resolve flaky unit test #34903
Conversation
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
/test |
@ishleenk17 , kindly help by reviewing. |
This pull request is now in conflicts. Could you fix it? 🙏
|
errorAfterEvent := 2 | ||
expectedHTTPEventCount := 6 | ||
expectedEventCount := 4 | ||
expectedEventCount := 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is a unit test having 2 events should be fine.
But, I hope this would work with more number of events as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, Input works properly with more number of events. We have kept it to 2 for unit testing purpose only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
* update unit test * add change log entry
What does this PR do?
TestMultiEventForEOFRetryHandlerInput
unit test of Filebeat CometD input is failing sometimes due to blockage of go channel . This unit test checks that CometD input is not closing input worker in case of client-server connection issue with EOF error.Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.