Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Filebeat][CometD] Resolve flaky unit test #34903

Merged
merged 3 commits into from
Apr 3, 2023

Conversation

niraj-elastic
Copy link
Contributor

  • Cleanup

What does this PR do?

TestMultiEventForEOFRetryHandlerInput unit test of Filebeat CometD input is failing sometimes due to blockage of go channel . This unit test checks that CometD input is not closing input worker in case of client-server connection issue with EOF error.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@niraj-elastic niraj-elastic requested a review from a team as a code owner March 23, 2023 05:29
@niraj-elastic niraj-elastic requested review from ycombinator and leehinman and removed request for a team March 23, 2023 05:29
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Mar 23, 2023
@mergify
Copy link
Contributor

mergify bot commented Mar 23, 2023

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @niraj-elastic? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 23, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-04-03T11:20:13.461+0000

  • Duration: 72 min 7 sec

Test stats 🧪

Test Results
Failed 0
Passed 2875
Skipped 173
Total 3048

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@kush-elastic
Copy link
Collaborator

/test

@kush-elastic kush-elastic added cleanup Team:Service-Integrations Label for the Service Integrations team and removed needs_team Indicates that the issue/PR needs a Team:* label labels Mar 23, 2023
@agithomas agithomas requested review from ishleenk17 and removed request for agithomas March 24, 2023 07:19
@agithomas
Copy link
Contributor

@ishleenk17 , kindly help by reviewing.

@mergify
Copy link
Contributor

mergify bot commented Mar 30, 2023

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b cometd_unit_test_update upstream/cometd_unit_test_update
git merge upstream/main
git push upstream cometd_unit_test_update

errorAfterEvent := 2
expectedHTTPEventCount := 6
expectedEventCount := 4
expectedEventCount := 2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a unit test having 2 events should be fine.
But, I hope this would work with more number of events as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, Input works properly with more number of events. We have kept it to 2 for unit testing purpose only.

Copy link
Contributor

@ishleenk17 ishleenk17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ishleenk17 ishleenk17 merged commit c4f86d6 into elastic:main Apr 3, 2023
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
* update unit test

* add change log entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Team:Service-Integrations Label for the Service Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants