Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure k8s watchers close when closing k8s meta processor #35630

Merged

Conversation

ChrsMark
Copy link
Member

What does this PR do?

This PR ensures that k8s watchers are closed when the add_k8s_metadata processor is closed.

Why is it important?

To gracefully close the processor.
Most probably this is the reason of elastic/elastic-agent-autodiscover#41.

Fixes #35495

Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
@ChrsMark ChrsMark self-assigned this May 31, 2023
@ChrsMark ChrsMark requested a review from a team as a code owner May 31, 2023 14:37
@ChrsMark ChrsMark requested review from gizas and constanca-m May 31, 2023 14:37
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 31, 2023
@mergify
Copy link
Contributor

mergify bot commented May 31, 2023

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @ChrsMark? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
@elasticmachine
Copy link
Collaborator

elasticmachine commented May 31, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-05-31T15:30:32.257+0000

  • Duration: 69 min 12 sec

Test stats 🧪

Test Results
Failed 0
Passed 26417
Skipped 1975
Total 28392

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@ChrsMark ChrsMark added backport Team:Cloudnative-Monitoring Label for the Cloud Native Monitoring team labels Jun 1, 2023
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jun 1, 2023
@ChrsMark ChrsMark merged commit e310ee2 into elastic:main Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

All k8s watchers should get stopped when k8s processor is stopped
4 participants