-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[awss3][automation] Fix skipping aws tests in automation #36054
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
Indicates that the issue/PR needs a Team:* label
label
Jul 12, 2023
bhapas
added
bugfix
and removed
needs_team
Indicates that the issue/PR needs a Team:* label
labels
Jul 12, 2023
botelastic
bot
added
the
needs_team
Indicates that the issue/PR needs a Team:* label
label
Jul 12, 2023
bhapas
added
Team:Security-External Integrations
8.10-candidate
backport-v8.9.0
Automated backport with mergify
and removed
needs_team
Indicates that the issue/PR needs a Team:* label
labels
Jul 12, 2023
Collaborator
/test |
bhapas
force-pushed
the
fix-aws-terraform-tests
branch
2 times, most recently
from
July 12, 2023 20:50
cdb8d98
to
01482e1
Compare
bhapas
force-pushed
the
fix-aws-terraform-tests
branch
from
July 12, 2023 21:09
01482e1
to
934488b
Compare
bhapas
force-pushed
the
fix-aws-terraform-tests
branch
2 times, most recently
from
July 13, 2023 06:02
7152585
to
b0f7b9a
Compare
bhapas
force-pushed
the
fix-aws-terraform-tests
branch
6 times, most recently
from
July 13, 2023 14:11
7f4d57a
to
b134c64
Compare
bhapas
force-pushed
the
fix-aws-terraform-tests
branch
from
July 13, 2023 20:55
b134c64
to
0d2fc4a
Compare
bhapas
force-pushed
the
fix-aws-terraform-tests
branch
2 times, most recently
from
July 14, 2023 12:16
91bbf14
to
18f5916
Compare
bhapas
force-pushed
the
fix-aws-terraform-tests
branch
from
July 14, 2023 20:57
19fffec
to
71b3b79
Compare
Closed
2 tasks
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
Pinging @elastic/elastic-agent (Team:Elastic-Agent) |
rdner
approved these changes
Jul 17, 2023
botelastic
bot
added
the
Team:Automation
Label for the Observability productivity team
label
Jul 17, 2023
bhapas
added
Team:Obs-InfraObs
Label for the Observability Infrastructure Monitoring team
Team:Cloud-Monitoring
Label for the Cloud Monitoring team
ci
and removed
Team:Security-External Integrations
Team:Obs-InfraObs
Label for the Observability Infrastructure Monitoring team
labels
Jul 17, 2023
andrewkroh
approved these changes
Jul 17, 2023
kaiyan-sheng
approved these changes
Jul 17, 2023
mergify bot
pushed a commit
that referenced
this pull request
Jul 17, 2023
* Unstash terraform config into correct directory * Fix Jenkinsfile * fix failing test * Mention issue for commented code (cherry picked from commit af2d773)
Scholar-Li
pushed a commit
to Scholar-Li/beats
that referenced
this pull request
Feb 5, 2024
* Unstash terraform config into correct directory * Fix Jenkinsfile * fix failing test * Mention issue for commented code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-v8.9.0
Automated backport with mergify
bugfix
ci
Team:Automation
Label for the Observability productivity team
Team:Cloud-Monitoring
Label for the Cloud Monitoring team
Team:Elastic-Agent
Label for the Agent team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes the Integration test CI job to run the
awss3 input_integration_test
on AWS resources which were getting skipped all the time.Current Behaviour
PR Fix
Full Log here - https://beats-ci.elastic.co/job/Beats/job/beats/job/PR-36054/27/consoleText
Additional issues found
While fixing the skipped tests issue, it has been observed that the input metrics added to the test were failing for both SQS and SNS tests and the test code has been commented out here
This is outside the scope of the PR and shall be looked at in separate issue - #36077
Why is it important?
The
awss3
input integration tests were never run and a false positive result is being returned on CI-->
Checklist
Related issues