Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default allow_older_versions to true #36884

Merged
merged 8 commits into from
Oct 19, 2023
Merged

Default allow_older_versions to true #36884

merged 8 commits into from
Oct 19, 2023

Conversation

fearful-symmetry
Copy link
Contributor

@fearful-symmetry fearful-symmetry commented Oct 17, 2023 •
edited by cmacknz
Loading

Proposed commit message

This changes the behavior of output.elasticsearch.allow_older_version to default to true, as well as bypasses the version check in serverless mode, as serverless ES is pegged to 8.11.

I did test this, although I'm still a little worried that there's some unintended consequences here. It's a fairly simple check, though.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@fearful-symmetry fearful-symmetry added Team:Elastic-Agent Label for the Agent team backport-v8.11.0 Automated backport with mergify labels Oct 17, 2023
@fearful-symmetry fearful-symmetry self-assigned this Oct 17, 2023
@fearful-symmetry fearful-symmetry requested review from a team as code owners October 17, 2023 22:36
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Oct 17, 2023
@fearful-symmetry fearful-symmetry mentioned this pull request Oct 17, 2023
Closed
@elasticmachine
Copy link
Collaborator

elasticmachine commented Oct 17, 2023 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Duration: 101 min 6 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@pierrehilbert pierrehilbert mentioned this pull request Oct 18, 2023
Closed
@cmacknz
Copy link
Member

cmacknz commented Oct 18, 2023

This should solve elastic/elastic-agent#2692, linking it to this PR.

cmacknz
cmacknz approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@cmacknz cmacknz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just make sure you test it against a real ES instance.

libbeat/cmd/instance/beat.go Show resolved Hide resolved
@cmacknz
Copy link
Member

cmacknz commented Oct 19, 2023

Force merging, the changes is small and is blocking serverless testing.

@cmacknz cmacknz merged commit e39b37e into elastic:main Oct 19, 2023
22 checks passed
mergify bot pushed a commit that referenced this pull request Oct 19, 2023
@fearful-symmetry @mergify
Default allow_older_versions to true (#36884)
8b29b79 
* default allow_older_versions to true

* fix removed file

* fix error message

* Changing tests according to behavior change

* update docs

* add changelog

---------

Co-authored-by: Pierre HILBERT <pierre.hilbert@elastic.co>
(cherry picked from commit e39b37e)
@mergify mergify bot mentioned this pull request Oct 19, 2023
Merged
rdner pushed a commit that referenced this pull request Oct 23, 2023
@mergify @fearful-symmetry
Default allow_older_versions to true (#36884) (#36917)
4554614 
* default allow_older_versions to true

* fix removed file

* fix error message

* Changing tests according to behavior change

* update docs

* add changelog

---------

Co-authored-by: Pierre HILBERT <pierre.hilbert@elastic.co>
(cherry picked from commit e39b37e)

Co-authored-by: Alex K <8418476+fearful-symmetry@users.noreply.github.com>
Scholar-Li pushed a commit to Scholar-Li/beats that referenced this pull request Feb 5, 2024
@fearful-symmetry @pierrehilbert @Scholar-Li
Default allow_older_versions to true (elastic#36884)
b868b69 
* default allow_older_versions to true

* fix removed file

* fix error message

* Changing tests according to behavior change

* update docs

* add changelog

---------

Co-authored-by: Pierre HILBERT <pierre.hilbert@elastic.co>
@kilfoyle kilfoyle mentioned this pull request Jun 20, 2024
Closed
This was referenced Jul 24, 2024
Merged
Merged
This was referenced Jul 24, 2024
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmacknz cmacknz cmacknz approved these changes

@faec faec Awaiting requested review from faec faec is a code owner automatically assigned from elastic/elastic-agent-data-plane

@leehinman leehinman Awaiting requested review from leehinman leehinman is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees

@fearful-symmetry fearful-symmetry

Labels
backport-v8.11.0 Automated backport with mergify Team:Elastic-Agent Label for the Agent team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Agent cannot connect to ES once it has been upgraded
4 participants
@fearful-symmetry @elasticmachine @cmacknz @pierrehilbert