filebeat: use zglob for wildcards #3795
Conversation
| @@ -32,7 +32,6 @@ import: | |||
| version: ca8abbf65d0e61dedf061f98bd3850f250e27539 | |||
| - package: github.com/samuel/go-thrift | |||
| version: 2187045faa54fce7f5028706ffeb2f2fc342aa7e | |||
| # This is the same as labix.org/v2/mgo. See https://github.com/Masterminds/glide/issues/221#issuecomment-179817757 | |||
There was a problem hiding this comment.
This seems to have gotten lost. Is there a way to keep it besides manually editing the file?
There was a problem hiding this comment.
Sounds like there isn't: Masterminds/glide#691
I'll re-add it
|
Ouch 29/54 of those patterns fail with |
There was a problem hiding this comment.
The file scanning is a central part of filebeat. Only had a quick look at zglob and it seems to do some additional magic. Do we need all of this? Would we use a simplified implementation owned by us which does only what we need?
Before we do a switch I would like to see the following:
- Pros / Cons of the switch because for example Golang did decide not to add it to the library
- Performance Comparison: Is this change having a potential performance impact? Some benchmark comparisons of the two would be interesting.
- Does zglob fall back to glob for "normal" cases?
| @@ -11,6 +11,7 @@ import ( | |||
| "github.com/elastic/beats/filebeat/input/file" | |||
| "github.com/elastic/beats/libbeat/logp" | |||
| "github.com/elastic/beats/libbeat/monitoring" | |||
| "github.com/mattn/go-zglob" | |||
There was a problem hiding this comment.
We normally put a new line between external and internal imports.
| @@ -115,3 +115,4 @@ import: | |||
| version: 5a004441f897722c627870a981d02b29924215fa | |||
| - package: github.com/mitchellh/hashstructure | |||
| version: b098c52ef6beab8cd82bc4a32422cf54b890e8fa | |||
| - package: github.com/mattn/go-zglob | |||
There was a problem hiding this comment.
In case we are going to use an external package, the exact commit id or version should be added.
There was a problem hiding this comment.
Yep not sure how that was missed. I'm going to revisit this anyways since zlog is clearly not a drop in replacement
| - /server/internal | ||
| - /server/v2 | ||
| - /protocol/v2 | ||
| - lj |
There was a problem hiding this comment.
Did this syntax change in glide?
|
We're coming up with a new solution, closing this |
No description provided.