Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.14](backport #38982) [libbeat] Fix parsing of RFC 3164 process IDs in syslog processor #39124

Merged
merged 2 commits into from
May 13, 2024
Merged

[8.14](backport #38982) [libbeat] Fix parsing of RFC 3164 process IDs in syslog processor #39124

merged 2 commits into from
May 13, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Apr 22, 2024 •
edited by zube bot
Loading

Proposed commit message

  • The pattern for parsing process IDs was too relaxed and would match everything between the first opening and the last closing square bracket in a message. If the message included multiple closing square brackets, the process ID would be set to not only the process ID, but also whatever leads up to the last closing square bracket.
  • The pattern has now been locked down to only digits.
  • Added test case.

Checklist

  • My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

This is an automatic backport of pull request #38982 done by [Mergify](https://mergify.com).

@taylor-swanson @mergify
[libbeat] Fix parsing of RFC 3164 process IDs in syslog processor (#3…
a6392c9 
…8982)

- The pattern for parsing process IDs was too relaxed and would
match everything between the first opening and the last closing
square bracket in a message. If the message included multiple
closing square brackets, the process ID would be set to not only
the process ID, but also whatever leads up to the last closing
square bracket.
- The pattern has now been locked down to only digits.
- Added test case.

(cherry picked from commit 8e9a276)
@mergify mergify bot requested a review from a team as a code owner April 22, 2024 13:36
@mergify mergify bot added the backport label Apr 22, 2024
@mergify mergify bot requested review from ycombinator and leehinman and removed request for a team April 22, 2024 13:36
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Apr 22, 2024
@botelastic
Copy link

botelastic bot commented Apr 22, 2024

This pull request doesn't have a Team:<team> label.

@elasticmachine
Copy link
Collaborator

elasticmachine commented Apr 22, 2024 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Duration: 29 min 56 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@mergify Mergify
Copy link
Contributor Author

mergify bot commented Apr 29, 2024

This pull request has not been merged yet. Could you please review and merge it @taylor-swanson? 🙏

@taylor-swanson
Copy link
Contributor

/test

@mergify Mergify
Copy link
Contributor Author

mergify bot commented May 6, 2024

This pull request has not been merged yet. Could you please review and merge it @taylor-swanson? 🙏

1 similar comment
@mergify Mergify
Copy link
Contributor Author

mergify bot commented May 13, 2024

This pull request has not been merged yet. Could you please review and merge it @taylor-swanson? 🙏

@taylor-swanson taylor-swanson enabled auto-merge (squash) May 13, 2024 13:57
@taylor-swanson taylor-swanson merged commit e119c79 into 8.14 May 13, 2024
183 of 186 checks passed
@taylor-swanson taylor-swanson deleted the mergify/bp/8.14/pr-38982 branch May 13, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkoutsovasilis pkoutsovasilis pkoutsovasilis approved these changes

@ycombinator ycombinator Awaiting requested review from ycombinator ycombinator is a code owner automatically assigned from elastic/elastic-agent-data-plane

@leehinman leehinman Awaiting requested review from leehinman leehinman is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees

@taylor-swanson taylor-swanson

Labels
backport needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elasticmachine @taylor-swanson @pkoutsovasilis