Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x-pack/filebeat/input/http_endpoint: fix request trace logging file names #39656

Merged
merged 1 commit into from
May 22, 2024
Merged

x-pack/filebeat/input/http_endpoint: fix request trace logging file names #39656

merged 1 commit into from
May 22, 2024

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented May 22, 2024 •
edited
Loading

Proposed commit message

This is a partial backport of #39410 to fix the missing replacement of
"*" with the input ID.

Note: This has been tested by injecting into an elastic-package-managed stack running the integration system tests in elastic/integrations#9909, and then examining the resulting request trace file from that.

Screenshot from 2024-05-22 12-53-59

Without this change the following is seen.

Screenshot from 2024-05-22 13-03-50

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@efd6 efd6 added Filebeat Filebeat backport-skip Skip notification from the automated backport with mergify bugfix Team:Security-Service Integrations Security Service Integrations Team labels May 22, 2024
@efd6 efd6 self-assigned this May 22, 2024
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels May 22, 2024
@efd6
x-pack/filebeat/input/http_endpoint: fix request trace logging file n…
944729f 
…ames

This is a partial backport of elastic#39410 to fix the missing replacement of
"*" with the input ID.
@efd6 efd6 force-pushed the i9909-http_endpoint branch from c139120 to 944729f Compare May 22, 2024 03:35
@efd6 efd6 marked this pull request as ready for review May 22, 2024 05:18
@efd6 efd6 requested a review from a team as a code owner May 22, 2024 05:18
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@efd6 efd6 enabled auto-merge (squash) May 22, 2024 05:18
@efd6 efd6 mentioned this pull request May 22, 2024
Merged
4 tasks
@efd6 efd6 merged commit 883e6c3 into elastic:8.14 May 22, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

Assignees

@efd6 efd6

Labels
backport-skip Skip notification from the automated backport with mergify bugfix Filebeat Filebeat Team:Security-Service Integrations Security Service Integrations Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@efd6 @elasticmachine @andrewkroh