Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dockerfile: keep nghttp2 up to date. #39694

Merged
merged 3 commits into from
May 24, 2024
Merged

Dockerfile: keep nghttp2 up to date. #39694

merged 3 commits into from
May 24, 2024

Conversation

cmacknz
Copy link
Member

@cmacknz cmacknz commented May 23, 2024

This will update nghttp2 and its dependent packages to the latest version.

@cmacknz cmacknz added Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.14.0 Automated backport with mergify labels May 23, 2024
@cmacknz cmacknz self-assigned this May 23, 2024
@cmacknz cmacknz requested a review from a team as a code owner May 23, 2024 14:08
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels May 23, 2024
@pierrehilbert pierrehilbert requested review from leehinman and removed request for rdner May 23, 2024 15:02
@belimawr
Copy link
Contributor

I've just had the same test failure in another PR. I believe main might be broken, I'm investigating.

Test failure:

2024-05-23 10:19:55 EDT	=== Failed
2024-05-23 10:19:55 EDT	=== FAIL: packetbeat/route TestDefault (0.91s)
2024-05-23 10:19:55 EDT	panic: runtime error: index out of range [3] with length 3 [recovered]
2024-05-23 10:19:55 EDT		panic: runtime error: index out of range [3] with length 3
2024-05-23 10:19:55 EDT	
2024-05-23 10:19:55 EDT	goroutine 6 [running]:
2024-05-23 10:19:55 EDT	testing.tRunner.func1.2({0x7c9340, 0xc000091380})
2024-05-23 10:19:55 EDT		C:/Users/Buildkite/.go/go-1.21.10/src/testing/testing.go:1545 +0x238
2024-05-23 10:19:55 EDT	testing.tRunner.func1()
2024-05-23 10:19:55 EDT		C:/Users/Buildkite/.go/go-1.21.10/src/testing/testing.go:1548 +0x397
2024-05-23 10:19:55 EDT	panic({0x7c9340?, 0xc000091380?})
2024-05-23 10:19:55 EDT		C:/Users/Buildkite/.go/go-1.21.10/src/runtime/panic.go:914 +0x21f
2024-05-23 10:19:55 EDT	github.com/elastic/beats/v7/packetbeat/route.defaultRoute(0xc00019a037?)
2024-05-23 10:19:55 EDT		C:/buildkite-agent/builds/bk-agent-prod-gcp-1716473459582555838/elastic/beats-packetbeat/packetbeat/route/route_windows_test.go:63 +0xd72
2024-05-23 10:19:55 EDT	github.com/elastic/beats/v7/packetbeat/route.TestDefault(0xc00003b520)
2024-05-23 10:19:55 EDT		C:/buildkite-agent/builds/bk-agent-prod-gcp-1716473459582555838/elastic/beats-packetbeat/packetbeat/route/route_test.go:36 +0x72
2024-05-23 10:19:55 EDT	testing.tRunner(0xc00003b520, 0x7ea630)
2024-05-23 10:19:55 EDT		C:/Users/Buildkite/.go/go-1.21.10/src/testing/testing.go:1595 +0xff
2024-05-23 10:19:55 EDT	created by testing.(*T).Run in goroutine 1
2024-05-23 10:19:55 EDT		C:/Users/Buildkite/.go/go-1.21.10/src/testing/testing.go:1648 +0x3ad
2024-05-23 10:19:55 EDT	
2024-05-23 10:19:55 EDT	DONE 402 tests, 1 failure in 151.373s
2024-05-23 10:19:55 EDT	Error: failed to execute go: exit status 1

@cmacknz cmacknz enabled auto-merge (squash) May 23, 2024 22:30
@cmacknz cmacknz merged commit 809e001 into elastic:main May 24, 2024
104 checks passed
mergify bot pushed a commit that referenced this pull request May 24, 2024
@cmacknz @mergify
Dockerfile: keep nghttp2 up to date. (#39694)
f156ac2 
* Keep nghttp2 up to date explicitly.

(cherry picked from commit 809e001)
mergify bot pushed a commit that referenced this pull request May 24, 2024
@cmacknz @mergify
Dockerfile: keep nghttp2 up to date. (#39694)
659344c 
* Keep nghttp2 up to date explicitly.

(cherry picked from commit 809e001)
This was referenced May 24, 2024
Closed
Closed
@cmacknz cmacknz deleted the update-nghttp2-docker branch May 24, 2024 01:18
cmacknz added a commit to cmacknz/beats that referenced this pull request May 24, 2024
@cmacknz
Revert "Dockerfile: keep nghttp2 up to date. (elastic#39694)"
031a777 
This reverts commit 809e001.
cmacknz added a commit that referenced this pull request May 27, 2024
@cmacknz
Revert "Dockerfile: keep nghttp2 up to date. (#39694)" (#39727)
19499ae 
This reverts commit 809e001.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leehinman leehinman leehinman approved these changes

@jlind23 jlind23 jlind23 approved these changes

@fearful-symmetry fearful-symmetry fearful-symmetry approved these changes

@pierrehilbert pierrehilbert pierrehilbert approved these changes

@belimawr belimawr belimawr approved these changes

Assignees

@cmacknz cmacknz

Labels
backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.14.0 Automated backport with mergify Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@cmacknz @elasticmachine @belimawr @pierrehilbert @fearful-symmetry @jlind23 @leehinman