Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependabot: add CSP SDKs to the allow list #40150

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Dependabot: add CSP SDKs to the allow list #40150

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions .github/dependabot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,18 +35,23 @@ updates:
- dependency-name: github.com/elastic/go-seccomp-bpf
- dependency-name: github.com/elastic/toutoumomoma
- dependency-name: github.com/elastic/ebpfevents
# Team:Team:obs-ds-hosted-services, Team:obs-infraobs-integrations
# Azure SDK dependencies
- dependency-name: github.com/Azure/azure-sdk-for-go/*
- dependency-name: github.com/Azure/azure-event-hubs-go/*
- dependency-name: github.com/Azure/azure-storage-blob-go/*
- dependency-name: github.com/Azure/go-autorest/*
# GCP SDK dependencies
- dependency-name: cloud.google.com/go/*
groups:
# Cloud providers' SDK dependencies
azure-sdks:
patterns:
- "github.com/Azure/azure-sdk-for-go/*"
- "github.com/Azure/azure-event-hubs-go/*"
- "github.com/Azure/azure-*-go"
- "github.com/Azure/go-autorest/*"
- "github.com/Azure/azure-storage-blob-go/*"
gcp-sdks:
patterns:
- "cloud.google.com/go/*"
- "google.golang.org/*"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just double checking: this is on purpose?

The namespace at least seems to exist https://pkg.go.dev/google.golang.org/api

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cloud.google.com/go/* packages focus on Google Cloud Platform (GCP) specifically, allowing the use of APIs for services like Compute Engine, Cloud Storage, BigQuery, Pub/Sub, and others.

The https://pkg.go.dev/google.golang.org/api packages are applicable instead for interacting with various Google APIs, such as Google Drive, Google Calendar, YouTube, and others.

For this Dependabot configuration, I want to focus only on GCP. My bad for not adding a comment in the PR description; I updated it accordingly).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dliappis, let me know what you think 🙇

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zmoog Thanks for the explanation. I will approve the PR on behalf of @dliappis since he isn't available this week.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @rowlandgeoff!

ignore:
# Skip github.com/elastic/mito because it requires documentation updates.
- dependency-name: github.com/elastic/mito
Expand Down
Loading