Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[filebeat] Initial port of powershell winlogbeat module #40519

Closed
wants to merge 13 commits into from

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Aug 14, 2024

Proposed commit message

Convert winlogbeat powershell and powershell_operational module into a new filebeat module using the winlog input.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Aug 14, 2024
Copy link
Contributor

mergify bot commented Aug 14, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @marc-gr? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@marc-gr marc-gr added the Team:Security-Windows Platform Windows Platform Team in Security Solution label Aug 29, 2024
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Aug 29, 2024
@marc-gr marc-gr added Filebeat Filebeat Winlogbeat needs_team Indicates that the issue/PR needs a Team:* label labels Aug 29, 2024
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Aug 29, 2024
@botelastic
Copy link

botelastic bot commented Aug 29, 2024

This pull request doesn't have a Team:<team> label.

@marc-gr marc-gr marked this pull request as ready for review August 29, 2024 09:40
@marc-gr marc-gr requested a review from a team as a code owner August 29, 2024 09:40
@marc-gr marc-gr requested review from rdner and faec August 29, 2024 09:40
@elasticmachine
Copy link
Collaborator

Pinging @elastic/sec-windows-platform (Team:Security-Windows Platform)

@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Aug 29, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@pierrehilbert pierrehilbert requested review from belimawr and leehinman and removed request for rdner August 29, 2024 10:51
@pierrehilbert pierrehilbert removed the request for review from faec August 29, 2024 10:51
Copy link
Contributor

@leehinman leehinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add an entry in the CODEOWNERS file for /x-pack/filebeat/module/windows ?

@marc-gr marc-gr requested a review from a team as a code owner August 29, 2024 14:02
Copy link
Contributor

mergify bot commented Aug 29, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b feat/powershell-filebeat-module upstream/feat/powershell-filebeat-module
git merge upstream/main
git push upstream feat/powershell-filebeat-module

@marc-gr marc-gr marked this pull request as draft August 30, 2024 09:55
@marc-gr
Copy link
Contributor Author

marc-gr commented Aug 30, 2024

Moved to draft since we need a bit more discussion around this

Copy link
Contributor

mergify bot commented Aug 31, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b feat/powershell-filebeat-module upstream/feat/powershell-filebeat-module
git merge upstream/main
git push upstream feat/powershell-filebeat-module

@marc-gr marc-gr closed this Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Filebeat Filebeat Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team Team:Security-Windows Platform Windows Platform Team in Security Solution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants