Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libbeat][parquet reader] - Added debug logs & improved batch_size tracking #40651

Merged
merged 6 commits into from
Sep 2, 2024
Merged

[libbeat][parquet reader] - Added debug logs & improved batch_size tracking #40651

merged 6 commits into from
Sep 2, 2024

Conversation

ShourieG
Copy link
Contributor

Type of change

  • Enhancement

Proposed commit message

Added debug logs to the parquet reader using a global instance of logp. This will enable better debugging of issues.
Improved batch size tracking via the config.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

None

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@ShourieG ShourieG requested a review from a team as a code owner August 29, 2024 09:14
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Aug 29, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 29, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @ShourieG? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@ShourieG ShourieG added the Team:Security-Service Integrations Security Service Integrations Team label Aug 29, 2024
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Aug 29, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@ShourieG ShourieG added enhancement needs_team Indicates that the issue/PR needs a Team:* label labels Aug 29, 2024
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Aug 29, 2024
@ShourieG ShourieG added needs_team Indicates that the issue/PR needs a Team:* label libbeat:reader labels Aug 29, 2024
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Aug 29, 2024
@ShourieG ShourieG added 8.16-candidate backport-8.15 Automated backport to the 8.15 branch with mergify labels Aug 29, 2024
@ShourieG ShourieG requested a review from efd6 August 29, 2024 09:19
efd6
efd6 reviewed Aug 29, 2024
View reviewed changes
x-pack/libbeat/reader/parquet/parquet.go Show resolved Hide resolved
x-pack/libbeat/reader/parquet/parquet.go Outdated Show resolved Hide resolved
x-pack/libbeat/reader/parquet/parquet.go Outdated Show resolved Hide resolved
x-pack/libbeat/reader/parquet/parquet.go Outdated Show resolved Hide resolved
x-pack/libbeat/reader/parquet/parquet.go Outdated Show resolved Hide resolved
x-pack/libbeat/reader/parquet/parquet_test.go Outdated Show resolved Hide resolved
x-pack/libbeat/reader/parquet/parquet_test.go Outdated Show resolved Hide resolved
@ShourieG ShourieG merged commit 7f317fd into elastic:main Sep 2, 2024
50 checks passed
mergify bot pushed a commit that referenced this pull request Sep 2, 2024
@ShourieG @mergify
[libbeat][parquet reader] - Added debug logs & improved batch_size tr…
bcaf219 
…acking (#40651)

(cherry picked from commit 7f317fd)
@mergify mergify bot mentioned this pull request Sep 2, 2024
Merged
6 tasks
ShourieG added a commit that referenced this pull request Sep 2, 2024
@mergify @ShourieG
[libbeat][parquet reader] - Added debug logs & improved batch_size tr…
88cc526 
…acking (#40651) (#40673)

(cherry picked from commit 7f317fd)

Co-authored-by: ShourieG <105607378+ShourieG@users.noreply.github.com>
@ShourieG ShourieG deleted the parquet_reader/add_debug_logs branch September 2, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efd6 efd6 efd6 approved these changes

Assignees

@ShourieG ShourieG

Labels
8.16-candidate backport-8.15 Automated backport to the 8.15 branch with mergify enhancement libbeat:reader Team:Security-Service Integrations Security Service Integrations Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ShourieG @elasticmachine @efd6