Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.15](backport #40694) [vSphere][datastore_cluster] Add support for new metrics in datastore_cluster metricset #40831

Merged
merged 1 commit into from
Sep 14, 2024

Conversation

ishleenk17
Copy link
Contributor

This is a manual backport of pull request #40694.

  • Enhancement

Description

Here are the following metrics to be added for the datastore cluster data stream in the vSphere metricbeat module. Here we added a new performance API to get more detailed information from vSphere.

Metrics Type Metrics API Field Mappings
Datastore cluster childEntity(type= datastore) Summary datastore.names
  childEntity(type= datastore) Summary datastore.count

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

…_cluster metricset (#40694)

* initial commit

* add childEntity

* add changelog entry

* resolve review comments
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 14, 2024
@botelastic
Copy link

botelastic bot commented Sep 14, 2024

This pull request doesn't have a Team:<team> label.

Copy link
Member

@shmsr shmsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. Merge, if CI passes.

@ishleenk17 ishleenk17 marked this pull request as ready for review September 14, 2024 15:10
@ishleenk17 ishleenk17 requested a review from a team as a code owner September 14, 2024 15:10
@ishleenk17 ishleenk17 merged commit b5f61eb into 8.15 Sep 14, 2024
29 checks passed
@ishleenk17 ishleenk17 deleted the vsphere/bp/8.15/pr-40694 branch September 14, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants