[8.x](backport #40678) [Metricbeat][vSphere] Support for configurable IntervalId for performance API #40897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ance API (#40678) * initial commit for intervalId supports for performance metrics * update docs and fix CI * Add changelog entry * fix CI * resolve review comments * fix loggers * resolved review comments * update versions * update UTs * update integration tests * 10s -> 20s * Update CHANGELOG.next.asciidoc Co-authored-by: Aman <38116245+devamanv@users.noreply.github.com> * Update metricbeat/docs/modules/vsphere.asciidoc Co-authored-by: Aman <38116245+devamanv@users.noreply.github.com> * make update * add recover for ToMetricSeries panic * return error instead just logging it. * remove restriction of interval IDs * remove unnecessary validations * remove recover and add empty condition * update changelog entry * Fix wrapping of errors in loggers * update data.json * update data.json * fix CI and loggers * update changelog entries * make update * fix changelog entries * update changelog entry --------- Co-authored-by: Aman <38116245+devamanv@users.noreply.github.com> (cherry picked from commit c75a7a4)
botelastic
bot
added
the
needs_team
kush-elastic
added
enhancement
Metricbeat
|
This pull request is now in conflicts. Could you fix it? 🙏 |
botelastic
bot
removed
the
needs_team
6 tasks
kush-elastic
requested review from
faec and
VihasMakwana
and removed request for
a team
ishleenk17
reviewed
Sep 30, 2024
| @@ -327,10 +326,21 @@ https://github.com/elastic/beats/compare/v8.8.1\...main[Check the HEAD diff] | |||
| - Add new metricset network for the vSphere module. {pull}40559[40559] | |||
| - Add new metricset resourcepool for the vSphere module. {pull}40456[40456] | |||
| - Log the total time taken for GCP `ListTimeSeries` and `AggregatedList` requests {pull}40661[40661] | |||
| - Add `use_kubeadm` config option in kubernetes module in order to toggle kubeadm-config api requests {pull}40086[40086] | |||
| - Log the total time taken for GCP `ListTimeSeries` and `AggregatedList` requests {pull}40661[40661] | |||
| - Add new metrics for the vSphere Host metricset. {pull}40429[40429] | |||
There was a problem hiding this comment.
Is this used from the last commit in main/8.15 ?
There was a problem hiding this comment.
This is after something merged to 8.x.
There was a problem hiding this comment.
I think i should remove them
There was a problem hiding this comment.
Yes, lets go as and when whatever was merged.
|
Please use the format/description for backport as done here |
kush-elastic
changed the title
ishleenk17
approved these changes
Sep 30, 2024
| @@ -327,10 +326,21 @@ https://github.com/elastic/beats/compare/v8.8.1\...main[Check the HEAD diff] | |||
| - Add new metricset network for the vSphere module. {pull}40559[40559] | |||
| - Add new metricset resourcepool for the vSphere module. {pull}40456[40456] | |||
| - Log the total time taken for GCP `ListTimeSeries` and `AggregatedList` requests {pull}40661[40661] | |||
| - Add `use_kubeadm` config option in kubernetes module in order to toggle kubeadm-config api requests {pull}40086[40086] | |||
| - Log the total time taken for GCP `ListTimeSeries` and `AggregatedList` requests {pull}40661[40661] | |||
| - Add new metrics for the vSphere Host metricset. {pull}40429[40429] | |||
There was a problem hiding this comment.
Yes, lets go as and when whatever was merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-Raised from: #40744
The vSphere Performance API offers support for Intervals and Levels, allowing users to collect various types of counters and metrics from vSphere environments. Depending on the configured Interval, the API provides detailed or aggregated performance data from vSphere.
For more information, refer to the following resources:
We can add support for configuration that help users collect the specific performance data they need.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues
This is manually backport of pull request #40678.