Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x](backport #40912) x-pack/filebeat/input/cel: make http functions always available #40933

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 20, 2024

Proposed commit message

HTTP functions were previously conditional on the resource URL being an HTTP/HTTPS URL. In hindsight, this offers no benefits and can result in confusing errors when the end user enters an invalid URL for an HTTP-based integration. Instead of a URL-related or HTTP-related error, the user is given a compilation error indicating that the HTTP-related function that are being called (and they may not be aware of in any way) are not valid references. So let's just always make them available.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs


This is an automatic backport of pull request #40912 done by [Mergify](https://mergify.com).

HTTP functions were previously conditional on the resource URL being an
HTTP/HTTPS URL. In hindsight, this offers no benefits and can result in
confusing errors when the end user enters an invalid URL for an HTTP-based
integration. Instead of a URL-related or HTTP-related error, the user is
given a compilation error indicating that the HTTP-related function that
are being called (and they may not be aware of in any way) are not valid
references. So let's just always make them available.

(cherry picked from commit 14337dd)
@mergify mergify bot requested a review from a team as a code owner September 20, 2024 20:57
@mergify mergify bot added the backport label Sep 20, 2024
@mergify mergify bot assigned efd6 Sep 20, 2024
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 20, 2024
@botelastic
Copy link

botelastic bot commented Sep 20, 2024

This pull request doesn't have a Team:<team> label.

Copy link
Contributor Author

mergify bot commented Sep 23, 2024

This pull request has not been merged yet. Could you please review and merge it @efd6? 🙏

Copy link
Contributor Author

mergify bot commented Sep 24, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b mergify/bp/8.x/pr-40912 upstream/mergify/bp/8.x/pr-40912
git merge upstream/8.x
git push upstream mergify/bp/8.x/pr-40912

@efd6 efd6 enabled auto-merge (squash) September 24, 2024 03:39
@efd6 efd6 merged commit 6114256 into 8.x Sep 24, 2024
16 of 19 checks passed
@efd6 efd6 deleted the mergify/bp/8.x/pr-40912 branch September 24, 2024 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant