Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x](backport #40879) [filbeat][azure-blob-storage] - Adding support for Microsoft Entra ID RBAC authentication #41060

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 1, 2024

Type of change

  • Enhancement
  • Docs

Proposed commit message

Added support for Microsoft Entra ID RBAC authentication.
Added mock tests by injecting the gock transport layer in the azure client.
Added some config tests with the new config options.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

No Impact

Live Testing

Live testing was performed using our internal Azure dev environment.
Process followed:

  1. Fresh storage account and container created and then uploaded with dummy files.
  2. New service principle app created.
  3. blobOwner role granted to service app via Entra ID IAM configs.
  4. client_id, tenant_id and client_secret of the service app used to poll poll the blob storage.
  5. Records were output to a local file with success.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Testing

We performed live testing internally using an active azure account and the new authentication system is working properly after assigning the service principal app with the blobOwner permission level.

Use cases

Screenshots

Screenshot 2024-09-19 at 6 29 07 PM Screenshot 2024-09-19 at 6 30 46 PM

Logs


This is an automatic backport of pull request #40879 done by [Mergify](https://mergify.com).

… RBAC authentication (#40879)

* Added support for Microsoft Entra ID RBAC authentication.

(cherry picked from commit c5d376c)
@mergify mergify bot requested a review from a team as a code owner October 1, 2024 11:18
@mergify mergify bot added the backport label Oct 1, 2024
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Oct 1, 2024
@botelastic
Copy link

botelastic bot commented Oct 1, 2024

This pull request doesn't have a Team:<team> label.

Copy link
Contributor Author

mergify bot commented Oct 7, 2024

This pull request has not been merged yet. Could you please review and merge it @ShourieG? 🙏

@ShourieG ShourieG merged commit d75e735 into 8.x Oct 8, 2024
22 checks passed
@ShourieG ShourieG deleted the mergify/bp/8.x/pr-40879 branch October 8, 2024 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant