-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
filebeat: input v2 compat uses random ID for CheckConfig #41585
Merged
AndersonQ
merged 10 commits into
elastic:main
from
AndersonQ:31767-filestream-id-already-exists
Nov 14, 2024
Merged
filebeat: input v2 compat uses random ID for CheckConfig #41585
AndersonQ
merged 10 commits into
elastic:main
from
AndersonQ:31767-filestream-id-already-exists
Nov 14, 2024
Commits on Nov 11, 2024
-
filebeat: input v2 compat uses random ID for CheckConfig
The CheckConfig function validates a configuration by creating and immediately discarding an input. However, a potential conflict arises when CheckConfig is used with autodiscover in Kubernetes. Autodiscover accumulates configuration changes and applies them in batches. This can be problematic if a stop event for a pod is closely followed by a start event for the same pod (e.g., during a pod restart) before the inputs are reloaded. In this scenario, autodiscover might attempt to validate the configuration for the start event while the input for the pod is already running. This would lead to filestream input manager to see two inputs with the same ID, triggering a log warning. Although this situation generates a warning, it doesn't result in data duplication. As the second input is only created to validate the configuration and later discarded. Also the reload process will ensure only new inputs are created, any input already running won't be duplicated.
Configuration menu - View commit details
-
Copy full SHA for 32f04e3 - Browse repository at this point
Copy the full SHA 32f04e3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5103cc1 - Browse repository at this point
Copy the full SHA 5103cc1View commit details
Commits on Nov 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d10e55f - Browse repository at this point
Copy the full SHA d10e55fView commit details -
Configuration menu - View commit details
-
Copy full SHA for ab8f727 - Browse repository at this point
Copy the full SHA ab8f727View commit details -
Merge remote-tracking branch 'origin/31767-filestream-id-already-exis…
…ts' into 31767-filestream-id-already-exists
Configuration menu - View commit details
-
Copy full SHA for 0481528 - Browse repository at this point
Copy the full SHA 0481528View commit details -
Configuration menu - View commit details
-
Copy full SHA for 67bcd91 - Browse repository at this point
Copy the full SHA 67bcd91View commit details -
Configuration menu - View commit details
-
Copy full SHA for fd66a37 - Browse repository at this point
Copy the full SHA fd66a37View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9fc2539 - Browse repository at this point
Copy the full SHA 9fc2539View commit details
Commits on Nov 14, 2024
-
Configuration menu - View commit details
-
Copy full SHA for de41ef4 - Browse repository at this point
Copy the full SHA de41ef4View commit details -
Merge remote-tracking branch 'origin/31767-filestream-id-already-exis…
…ts' into 31767-filestream-id-already-exists
Configuration menu - View commit details
-
Copy full SHA for 51fabd3 - Browse repository at this point
Copy the full SHA 51fabd3View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.