Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[winlogbeat] Fix how we check for dynamic values in message templates #41730

Merged
merged 4 commits into from
Nov 22, 2024
Merged

[winlogbeat] Fix how we check for dynamic values in message templates #41730

merged 4 commits into from
Nov 22, 2024

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Nov 21, 2024

Proposed commit message

  • Fix how we check for dynamic values in message templates.
    In the experimental api we set a static message under the assumption it was not a dynamic template in cases where the whole
    message was a single data value.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@marc-gr marc-gr added bugfix backport-8.x Automated backport to the 8.x branch with mergify backport-8.17 Automated backport with mergify labels Nov 21, 2024
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Nov 21, 2024
@marc-gr marc-gr added Winlogbeat Team:Security-Windows Platform Windows Platform Team in Security Solution labels Nov 21, 2024
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Nov 21, 2024
@marc-gr marc-gr marked this pull request as ready for review November 21, 2024 10:36
@marc-gr marc-gr requested a review from a team as a code owner November 21, 2024 10:36
@elasticmachine
Copy link
Collaborator

Pinging @elastic/sec-windows-platform (Team:Security-Windows Platform)

@cla-checker-service CLA Checker Service
Copy link

cla-checker-service bot commented Nov 22, 2024 •
edited
Loading

💚 CLA has been signed

@marc-gr marc-gr merged commit 61df1f2 into elastic:main Nov 22, 2024
28 checks passed
@marc-gr marc-gr deleted the fix/winlogbeat-exp-msg branch November 22, 2024 10:47
mergify bot pushed a commit that referenced this pull request Nov 22, 2024
@marc-gr @mergify
[winlogbeat] Fix how we check for dynamic values in message templates (…
341ede2 
…#41730)

* Fix how we check for dynamic values in message templates

* Fix test

* Remove dokan1 test

(cherry picked from commit 61df1f2)
@mergify mergify bot mentioned this pull request Nov 22, 2024
Merged
6 tasks
mergify bot pushed a commit that referenced this pull request Nov 22, 2024
@marc-gr @mergify
[winlogbeat] Fix how we check for dynamic values in message templates (…
96fe3a3 
…#41730)

* Fix how we check for dynamic values in message templates

* Fix test

* Remove dokan1 test

(cherry picked from commit 61df1f2)
@mergify mergify bot mentioned this pull request Nov 22, 2024
Merged
6 tasks
marc-gr added a commit that referenced this pull request Nov 22, 2024
@mergify @marc-gr
[winlogbeat] Fix how we check for dynamic values in message templates (…
3cd5905 
…#41730) (#41745)

* Fix how we check for dynamic values in message templates

* Fix test

* Remove dokan1 test

(cherry picked from commit 61df1f2)

Co-authored-by: Marc Guasch <marc-gr@users.noreply.github.com>
marc-gr added a commit that referenced this pull request Nov 22, 2024
@mergify @marc-gr
[winlogbeat] Fix how we check for dynamic values in message templates (…
9ec41ea 
…#41730) (#41746)

* Fix how we check for dynamic values in message templates

* Fix test

* Remove dokan1 test

(cherry picked from commit 61df1f2)

Co-authored-by: Marc Guasch <marc-gr@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nfritts nfritts nfritts approved these changes

Assignees

@marc-gr marc-gr

Labels
backport-8.x Automated backport to the 8.x branch with mergify backport-8.17 Automated backport with mergify bugfix Team:Security-Windows Platform Windows Platform Team in Security Solution Winlogbeat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Winlogbeat: Experimental API wrong message extraction with invalid events
3 participants
@marc-gr @elasticmachine @nfritts