[x-pack][iis] capture extra .NET CLR metrics #41929

stefans-elastic · 2024-12-06T11:45:39Z

Proposed commit message

This is part of elastic/integrations#7992 (exposing extra .NET ASP metrics in IIS metricbeat module(x-pack)).

!! IMPORTANT NOTE: the metrics don't show up if ASP.NET isn't installed

Checklist

My code follows the style guidelines of this project
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have made corresponding change to the default configuration files
I have added tests that prove my fix is effective or that my feature works
I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

[ ]

How to test this PR locally

Related issues

Relates elastic/integrations#7992

Use cases

Screenshots

Logs

mergify · 2024-12-06T11:46:23Z

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @stefans-elastic? 🙏.
For such, you'll need to label your PR with:

The upcoming major version of the Elastic Stack
The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit

mergify · 2024-12-06T11:46:24Z

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

x-pack/metricbeat/module/iis/application_pool/reader.go

muthu-mps · 2024-12-09T11:10:30Z

@stefans-elastic - Can you update the data.json file with the sample document with the memory and locksandthreads data?

stefans-elastic · 2024-12-09T13:32:18Z

@stefans-elastic - Can you update the data.json file with the sample document with the memory and locksandthreads data?

done

x-pack/metricbeat/module/iis/application_pool/_meta/fields.yml

…/beats into extra_iis_dotnet_metrics

…s_dotnet_metrics

CHANGELOG.next.asciidoc

muthu-mps · 2024-12-11T05:36:12Z

x-pack/metricbeat/module/iis/application_pool/reader.go

+	"net_clr.memory.gen_1_heap_size":         "\\.NET CLR Memory(w3wp*)\\Gen 1 heap size",
+	"net_clr.memory.gen_2_heap_size":         "\\.NET CLR Memory(w3wp*)\\Gen 2 heap size",
+	"net_clr.memory.large_object_heap_size":  "\\.NET CLR Memory(w3wp*)\\Large Object Heap size",
+	"net_clr.memory.time_in_gc_perc":         "\\.NET CLR Memory(w3wp*)\\% Time in GC",


time_in_gc_perc - What perc represents here?

It means percentage
I followed example from

"process.cpu_usage_perc": "\\Process(w3wp*)\\% Processor Time",

The naming convention for the percentage fields is something like, process.cpu_usage.pct. As the other fields already have _perc as a naming convention for percentage fields its better to align with the existing field name instead of introducing a different format for this field.

so I should leave it as it is, right?

yes, The reason for not changing is to keep it consistent with the existing fields.

Co-authored-by: muthu-mps <101238137+muthu-mps@users.noreply.github.com>

…s_dotnet_metrics

x-pack/metricbeat/module/iis/application_pool/_meta/fields.yml

muthu-mps · 2024-12-16T06:32:26Z

x-pack/metricbeat/module/iis/application_pool/_meta/data.json

@@ -9,7 +9,28 @@
        "application_pool": {
            "name": "test.local",
            "net_clr": {
-                "total_exceptions_thrown": 0
+                "total_exceptions_thrown": 0,


Since we don't have the ASP.NET application setup to test the real metrics flow. This step will be done later by identifying a mechanism to test the actual metrics generated by running the .NET application.

Co-authored-by: muthu-mps <101238137+muthu-mps@users.noreply.github.com>

muthu-mps

LGTM!

* [x-pack][iis] capture extra .NET CLR metrics * update changelog * update docs * update docs * remove unused field * fix error handling * fix missing import * mage update changes * update docs * docs * update net_clr fields mapping * update docs * correct fields naming for backwards compatibility * doc update * Update CHANGELOG.next.asciidoc Co-authored-by: muthu-mps <101238137+muthu-mps@users.noreply.github.com> * Update x-pack/metricbeat/module/iis/application_pool/_meta/fields.yml Co-authored-by: muthu-mps <101238137+muthu-mps@users.noreply.github.com> * update iis fields * update docs --------- Co-authored-by: muthu-mps <101238137+muthu-mps@users.noreply.github.com> (cherry picked from commit d42aab1)

* [x-pack][iis] capture extra .NET CLR metrics * update changelog * update docs * update docs * remove unused field * fix error handling * fix missing import * mage update changes * update docs * docs * update net_clr fields mapping * update docs * correct fields naming for backwards compatibility * doc update * Update CHANGELOG.next.asciidoc Co-authored-by: muthu-mps <101238137+muthu-mps@users.noreply.github.com> * Update x-pack/metricbeat/module/iis/application_pool/_meta/fields.yml Co-authored-by: muthu-mps <101238137+muthu-mps@users.noreply.github.com> * update iis fields * update docs --------- Co-authored-by: muthu-mps <101238137+muthu-mps@users.noreply.github.com> (cherry picked from commit d42aab1) Co-authored-by: stefans-elastic <stefan.stas@elastic.co>

* [x-pack][iis] capture extra .NET CLR metrics * update changelog * update docs * update docs * remove unused field * fix error handling * fix missing import * mage update changes * update docs * docs * update net_clr fields mapping * update docs * correct fields naming for backwards compatibility * doc update * Update CHANGELOG.next.asciidoc Co-authored-by: muthu-mps <101238137+muthu-mps@users.noreply.github.com> * Update x-pack/metricbeat/module/iis/application_pool/_meta/fields.yml Co-authored-by: muthu-mps <101238137+muthu-mps@users.noreply.github.com> * update iis fields * update docs --------- Co-authored-by: muthu-mps <101238137+muthu-mps@users.noreply.github.com> (cherry picked from commit d42aab1)

…42334) * [x-pack][iis] capture extra .NET CLR metrics (#41929) * [x-pack][iis] capture extra .NET CLR metrics * update changelog * update docs * update docs * remove unused field * fix error handling * fix missing import * mage update changes * update docs * docs * update net_clr fields mapping * update docs * correct fields naming for backwards compatibility * doc update * Update CHANGELOG.next.asciidoc Co-authored-by: muthu-mps <101238137+muthu-mps@users.noreply.github.com> * Update x-pack/metricbeat/module/iis/application_pool/_meta/fields.yml Co-authored-by: muthu-mps <101238137+muthu-mps@users.noreply.github.com> * update iis fields * update docs --------- Co-authored-by: muthu-mps <101238137+muthu-mps@users.noreply.github.com> (cherry picked from commit d42aab1) * remove unrelated entries from changelog --------- Co-authored-by: stefans-elastic <stefan.stas@elastic.co> Co-authored-by: muthu-mps <101238137+muthu-mps@users.noreply.github.com>

[x-pack][iis] capture extra .NET CLR metrics

de69a19

stefans-elastic added enhancement Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team labels Dec 6, 2024

stefans-elastic self-assigned this Dec 6, 2024

stefans-elastic requested a review from a team as a code owner December 6, 2024 11:45

botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Dec 6, 2024

mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Dec 6, 2024

stefans-elastic added 10 commits December 6, 2024 11:47

update changelog

baf36bb

update docs

8cb8d8c

update docs

7d1d16d

remove unused field

b3a8349

fix error handling

f17d6b9

Merge branch 'main' into extra_iis_dotnet_metrics

dcc6122

fix missing import

c6f27eb

mage update changes

fa0e9a0

update docs

b1fa68c

docs

cc47264

muthu-mps reviewed Dec 9, 2024

View reviewed changes

x-pack/metricbeat/module/iis/application_pool/reader.go Outdated Show resolved Hide resolved

stefans-elastic added 2 commits December 9, 2024 12:07

update net_clr fields mapping

2a3a132

update docs

d6a974b

stefans-elastic requested a review from muthu-mps December 9, 2024 13:32

muthu-mps reviewed Dec 9, 2024

View reviewed changes

x-pack/metricbeat/module/iis/application_pool/_meta/fields.yml Outdated Show resolved Hide resolved

stefans-elastic added 3 commits December 9, 2024 15:47

correct fields naming for backwards compatibility

26be568

Merge branch 'extra_iis_dotnet_metrics' of github.com:stefans-elastic…

cf5fed0

…/beats into extra_iis_dotnet_metrics

Merge branch 'main' of github.com:stefans-elastic/beats into extra_ii…

4ef236e

…s_dotnet_metrics

doc update

2b5cccf

muthu-mps reviewed Dec 11, 2024

View reviewed changes

muthu-mps and others added 2 commits December 11, 2024 11:13

Merge branch 'main' into extra_iis_dotnet_metrics

1e83dd5

Update CHANGELOG.next.asciidoc

62d50f7

Co-authored-by: muthu-mps <101238137+muthu-mps@users.noreply.github.com>

stefans-elastic requested a review from muthu-mps December 11, 2024 07:48

stefans-elastic added 2 commits December 12, 2024 16:04

Merge branch 'main' of github.com:stefans-elastic/beats into extra_ii…

eb65345

…s_dotnet_metrics

Merge branch 'main' of github.com:stefans-elastic/beats into extra_ii…

44537c0

…s_dotnet_metrics

muthu-mps reviewed Dec 16, 2024

View reviewed changes

x-pack/metricbeat/module/iis/application_pool/_meta/fields.yml Outdated Show resolved Hide resolved

Merge branch 'main' into extra_iis_dotnet_metrics

6443951

muthu-mps reviewed Dec 16, 2024

View reviewed changes

stefans-elastic and others added 5 commits December 16, 2024 10:14

Update x-pack/metricbeat/module/iis/application_pool/_meta/fields.yml

e481d49

Co-authored-by: muthu-mps <101238137+muthu-mps@users.noreply.github.com>

update iis fields

0f98b9e

update docs

0dd3a70

Merge branch 'main' into extra_iis_dotnet_metrics

1f298cf

Merge branch 'main' into extra_iis_dotnet_metrics

e15d4c8

muthu-mps approved these changes Dec 19, 2024

View reviewed changes

stefans-elastic merged commit d42aab1 into elastic:main Dec 19, 2024
32 checks passed

stefans-elastic deleted the extra_iis_dotnet_metrics branch December 19, 2024 08:31

mergify bot mentioned this pull request Dec 19, 2024

[8.x](backport #41929) [x-pack][iis] capture extra .NET CLR metrics #42118

Merged

6 tasks

muthu-mps added the backport-8.17 Automated backport with mergify label Jan 17, 2025

mergify bot mentioned this pull request Jan 17, 2025

[8.17](backport #41929) [x-pack][iis] capture extra .NET CLR metrics #42334

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[x-pack][iis] capture extra .NET CLR metrics #41929

[x-pack][iis] capture extra .NET CLR metrics #41929

stefans-elastic commented Dec 6, 2024

mergify bot commented Dec 6, 2024

mergify bot commented Dec 6, 2024

muthu-mps commented Dec 9, 2024

stefans-elastic commented Dec 9, 2024

muthu-mps Dec 11, 2024

stefans-elastic Dec 11, 2024

muthu-mps Dec 16, 2024

stefans-elastic Dec 16, 2024

muthu-mps Dec 16, 2024

muthu-mps Dec 16, 2024

muthu-mps left a comment

[x-pack][iis] capture extra .NET CLR metrics #41929

[x-pack][iis] capture extra .NET CLR metrics #41929

Conversation

stefans-elastic commented Dec 6, 2024

Proposed commit message

Checklist

Disruptive User Impact

Author's Checklist

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

mergify bot commented Dec 6, 2024

mergify bot commented Dec 6, 2024

muthu-mps commented Dec 9, 2024

stefans-elastic commented Dec 9, 2024

muthu-mps Dec 11, 2024

Choose a reason for hiding this comment

stefans-elastic Dec 11, 2024

Choose a reason for hiding this comment

muthu-mps Dec 16, 2024

Choose a reason for hiding this comment

stefans-elastic Dec 16, 2024

Choose a reason for hiding this comment

muthu-mps Dec 16, 2024

Choose a reason for hiding this comment

muthu-mps Dec 16, 2024

Choose a reason for hiding this comment

muthu-mps left a comment

Choose a reason for hiding this comment