Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[filebeat][streaming] - Added default values for websocket retries & put a cap on waitTime to be <= waitMax #42012

Merged
merged 3 commits into from
Dec 13, 2024
Merged

[filebeat][streaming] - Added default values for websocket retries & put a cap on waitTime to be <= waitMax #42012

merged 3 commits into from
Dec 13, 2024

Conversation

ShourieG
Copy link
Contributor

@ShourieG ShourieG commented Dec 12, 2024 •
edited
Loading

Type of change

  • Enhancement

Proposed commit message

Added default values for websocket retries & put a cap on waitTime to be <= waitMax. Updated the documentation accordingly. Capping the waitMax value avoids long/indefinite wait times that can be caused due to backoff calculation.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@ShourieG ShourieG requested a review from a team as a code owner December 12, 2024 11:13
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Dec 12, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 12, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @ShourieG? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 12, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Dec 12, 2024
@ShourieG ShourieG added the Team:Security-Service Integrations Security Service Integrations Team label Dec 12, 2024
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Dec 12, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@ShourieG ShourieG added enhancement needs_team Indicates that the issue/PR needs a Team:* label labels Dec 12, 2024
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Dec 12, 2024
@ShourieG ShourieG added needs_team Indicates that the issue/PR needs a Team:* label input:streaming labels Dec 12, 2024
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Dec 12, 2024
@ShourieG ShourieG added Filebeat Filebeat needs_team Indicates that the issue/PR needs a Team:* label labels Dec 12, 2024
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Dec 12, 2024
@ShourieG ShourieG added needs_team Indicates that the issue/PR needs a Team:* label backport-8.16 Automated backport with mergify backport-8.17 Automated backport with mergify labels Dec 12, 2024
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Dec 12, 2024
@botelastic
Copy link

botelastic bot commented Dec 12, 2024

This pull request doesn't have a Team:<team> label.

chemamartinez
chemamartinez approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@chemamartinez chemamartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShourieG ShourieG merged commit 5ed055b into elastic:main Dec 13, 2024
22 checks passed
mergify bot pushed a commit that referenced this pull request Dec 13, 2024
@ShourieG @mergify
[filebeat][streaming] - Added default values for websocket retries & …
02ded70 
…put a cap on waitTime to be <= waitMax (#42012)

* added default retry values and ensured a cap on waitTime i.e now waitTime <= wait_max

* updated changelog

(cherry picked from commit 5ed055b)
@mergify mergify bot mentioned this pull request Dec 13, 2024
Merged
6 tasks
@ShourieG ShourieG deleted the streaming/default_websocket_retry branch December 13, 2024 09:35
mergify bot pushed a commit that referenced this pull request Dec 13, 2024
@ShourieG @mergify
[filebeat][streaming] - Added default values for websocket retries & …
d16dc0a 
…put a cap on waitTime to be <= waitMax (#42012)

* added default retry values and ensured a cap on waitTime i.e now waitTime <= wait_max

* updated changelog

(cherry picked from commit 5ed055b)
@mergify mergify bot mentioned this pull request Dec 13, 2024
Merged
6 tasks
mergify bot pushed a commit that referenced this pull request Dec 13, 2024
@ShourieG @mergify
[filebeat][streaming] - Added default values for websocket retries & …
27864b4 
…put a cap on waitTime to be <= waitMax (#42012)

* added default retry values and ensured a cap on waitTime i.e now waitTime <= wait_max

* updated changelog

(cherry picked from commit 5ed055b)
@mergify mergify bot mentioned this pull request Dec 13, 2024
Merged
6 tasks
ShourieG added a commit that referenced this pull request Dec 13, 2024
@mergify @ShourieG
[filebeat][streaming] - Added default values for websocket retries & …
cd0f3aa 
…put a cap on waitTime to be <= waitMax (#42012) (#42029)

* added default retry values and ensured a cap on waitTime i.e now waitTime <= wait_max

* updated changelog

(cherry picked from commit 5ed055b)

Co-authored-by: ShourieG <shourie.ganguly@elastic.co>
ShourieG added a commit that referenced this pull request Dec 13, 2024
@mergify @ShourieG
[8.17](backport #42012) [filebeat][streaming] - Added default values …
9ea9d46 
…for websocket retries & put a cap on waitTime to be <= waitMax (#42030)

* [filebeat][streaming] - Added default values for websocket retries & put a cap on waitTime to be <= waitMax (#42012)

* added default retry values and ensured a cap on waitTime i.e now waitTime <= wait_max

* updated changelog

(cherry picked from commit 5ed055b)

* Update CHANGELOG.next.asciidoc

---------

Co-authored-by: ShourieG <shourie.ganguly@elastic.co>
ShourieG added a commit that referenced this pull request Dec 13, 2024
@mergify @ShourieG
[8.16](backport #42012) [filebeat][streaming] - Added default values …
6b51d13 
…for websocket retries & put a cap on waitTime to be <= waitMax (#42028)

* [filebeat][streaming] - Added default values for websocket retries & put a cap on waitTime to be <= waitMax (#42012)

* added default retry values and ensured a cap on waitTime i.e now waitTime <= wait_max

* updated changelog

(cherry picked from commit 5ed055b)

* Update CHANGELOG.next.asciidoc

---------

Co-authored-by: ShourieG <shourie.ganguly@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chemamartinez chemamartinez chemamartinez approved these changes

Assignees

@ShourieG ShourieG

Labels
backport-8.x Automated backport to the 8.x branch with mergify backport-8.16 Automated backport with mergify backport-8.17 Automated backport with mergify enhancement Filebeat Filebeat input:streaming Team:Security-Service Integrations Security Service Integrations Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ShourieG @elasticmachine @chemamartinez