Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.17](backport #42397) [metricbeat] [meraki] Ignore 400 error for unsupported per-device licensing #42467

Merged
merged 2 commits into from
Jan 29, 2025
Merged

[8.17](backport #42397) [metricbeat] [meraki] Ignore 400 error for unsupported per-device licensing #42467

merged 2 commits into from
Jan 29, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 29, 2025

Overview

We should continue collecting metrics even if the getDeviceLicenses function errors with 400 status code.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

This is an automatic backport of pull request #42397 done by [Mergify](https://mergify.com).

@gpop63 @mergify
[metricbeat] [meraki] Ignore 400 error for unsupported per-device lic…
bb1a98f 
…ensing (#42397)

* dont error in getDeviceLicenses

* add changelog entry

* fix pr id

* keep error and check for bad request

* check response body

---------

Co-authored-by: Ishleen Kaur <102962586+ishleenk17@users.noreply.github.com>
(cherry picked from commit b5f726b)
@mergify mergify bot requested a review from a team as a code owner January 29, 2025 10:32
@mergify mergify bot added the backport label Jan 29, 2025
@mergify mergify bot requested review from khushijain21 and VihasMakwana and removed request for a team January 29, 2025 10:32
@mergify mergify bot assigned gpop63 Jan 29, 2025
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jan 29, 2025
@botelastic
Copy link

botelastic bot commented Jan 29, 2025

This pull request doesn't have a Team:<team> label.

@gpop63 gpop63 merged commit 3da4be4 into 8.17 Jan 29, 2025
22 checks passed
@gpop63 gpop63 deleted the mergify/bp/8.17/pr-42397 branch January 29, 2025 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpop63 gpop63 gpop63 approved these changes

@khushijain21 khushijain21 Awaiting requested review from khushijain21 khushijain21 is a code owner automatically assigned from elastic/elastic-agent-data-plane

@VihasMakwana VihasMakwana Awaiting requested review from VihasMakwana VihasMakwana is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees

@gpop63 gpop63

Labels
backport needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gpop63