Journald reader: correctly handle journalctl restart #42595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
belimawr
added
bugfix
backport-8.x
botelastic
bot
added
the
needs_team
The journald reader would return an error and an empty message when journalctl was restarting, that would break the multiline parser. This commit fixes it by handling the "retry read" in the reader itself.
belimawr
force-pushed
the
41331-handle-journalctl-restarts
branch
from
a0edcb6 to
0d5ae7b
Compare
belimawr
added
the
Team:Elastic-Agent-Data-Plane
botelastic
bot
removed
the
needs_team
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
VihasMakwana
approved these changes
Feb 5, 2025
mergify bot
pushed a commit
that referenced
this pull request
Feb 7, 2025
The journald reader would return an error and an empty message when journalctl was restarting, that would break the multiline parser. This commit fixes it by handling the "retry read" in the reader itself. (cherry picked from commit 1cd128b)
6 tasks
mergify bot
pushed a commit
that referenced
this pull request
Feb 7, 2025
The journald reader would return an error and an empty message when journalctl was restarting, that would break the multiline parser. This commit fixes it by handling the "retry read" in the reader itself. (cherry picked from commit 1cd128b)
mergify bot
pushed a commit
that referenced
this pull request
Feb 7, 2025
The journald reader would return an error and an empty message when journalctl was restarting, that would break the multiline parser. This commit fixes it by handling the "retry read" in the reader itself. (cherry picked from commit 1cd128b)
This was referenced Feb 7, 2025
mergify bot
pushed a commit
that referenced
this pull request
Feb 7, 2025
The journald reader would return an error and an empty message when journalctl was restarting, that would break the multiline parser. This commit fixes it by handling the "retry read" in the reader itself. (cherry picked from commit 1cd128b)
6 tasks
belimawr
added a commit
that referenced
this pull request
Feb 7, 2025
The journald reader would return an error and an empty message when journalctl was restarting, that would break the multiline parser. This commit fixes it by handling the "retry read" in the reader itself. (cherry picked from commit 1cd128b) Co-authored-by: Tiago Queiroz <tiago.queiroz@elastic.co>
belimawr
added a commit
that referenced
this pull request
Feb 7, 2025
The journald reader would return an error and an empty message when journalctl was restarting, that would break the multiline parser. This commit fixes it by handling the "retry read" in the reader itself. (cherry picked from commit 1cd128b) Co-authored-by: Tiago Queiroz <tiago.queiroz@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
The journald reader would return an error and an empty message when journalctl was restarting, that would break the multiline parser.
This commit fixes it by handling the "retry read" in the reader itself.
Checklist
I have made corresponding changes to the documentationI have made corresponding change to the default configuration filesCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.## Disruptive User Impact## Author's ChecklistHow to test this PR locally
Related issues
## Use cases## Screenshots## Logs