Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Journald] Add tests to ensure no data duplication on restart #42596

Merged
merged 5 commits into from
Feb 7, 2025
Merged

[Journald] Add tests to ensure no data duplication on restart #42596

merged 5 commits into from
Feb 7, 2025

Conversation

belimawr
Copy link
Contributor

@belimawr belimawr commented Feb 4, 2025

Proposed commit message

See title

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

## Disruptive User Impact
## Author's Checklist

How to test this PR locally

Run the new test:

cd filebeat
go test -tags=integration -count=1 -v -run=TestJournaldInputDoesNotDuplicateData ./tests/integration

Related issues

## Use cases
## Screenshots
## Logs

@belimawr belimawr added Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team backport-8.x Automated backport to the 8.x branch with mergify labels Feb 4, 2025
@belimawr belimawr self-assigned this Feb 4, 2025
@belimawr belimawr requested a review from a team as a code owner February 4, 2025 22:05
@belimawr belimawr requested review from AndersonQ and rdner February 4, 2025 22:05
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Feb 4, 2025
@pierrehilbert
Copy link
Collaborator

@belimawr Shouldn't we backport this also in 9.0?

@belimawr belimawr added the backport-9.0 Automated backport to the 9.0 branch label Feb 5, 2025
@belimawr
Copy link
Contributor Author

belimawr commented Feb 5, 2025

@belimawr Shouldn't we backport this also in 9.0?

We should, thanks!

@belimawr
Copy link
Contributor Author

belimawr commented Feb 5, 2025

The CI failure is unrelated: #42616

AndersonQ
AndersonQ approved these changes Feb 6, 2025
View reviewed changes
filebeat/tests/integration/journald_test.go Show resolved Hide resolved
filebeat/tests/integration/journald_test.go Outdated Show resolved Hide resolved
@belimawr belimawr merged commit 3e2cec5 into elastic:main Feb 7, 2025
30 checks passed
mergify bot pushed a commit that referenced this pull request Feb 7, 2025
@belimawr @mergify
[Journald] Add tests to ensure no data duplication on restart (#42596)
93c082f 
(cherry picked from commit 3e2cec5)
@mergify mergify bot mentioned this pull request Feb 7, 2025
Merged
6 tasks
mergify bot pushed a commit that referenced this pull request Feb 7, 2025
@belimawr @mergify
[Journald] Add tests to ensure no data duplication on restart (#42596)
b670a72 
(cherry picked from commit 3e2cec5)
@mergify mergify bot mentioned this pull request Feb 7, 2025
Merged
6 tasks
belimawr added a commit that referenced this pull request Feb 10, 2025
@mergify @belimawr
[Journald] Add tests to ensure no data duplication on restart (#42596) (
b46055f 
#42641)

(cherry picked from commit 3e2cec5)

Co-authored-by: Tiago Queiroz <tiago.queiroz@elastic.co>
belimawr added a commit that referenced this pull request Feb 10, 2025
@mergify @belimawr
[Journald] Add tests to ensure no data duplication on restart (#42596) (
bf91bc4 
#42642)

(cherry picked from commit 3e2cec5)

Co-authored-by: Tiago Queiroz <tiago.queiroz@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndersonQ AndersonQ AndersonQ approved these changes

@rdner rdner Awaiting requested review from rdner rdner is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees

@belimawr belimawr

Labels
backport-8.x Automated backport to the 8.x branch with mergify backport-9.0 Automated backport to the 9.0 branch Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add test to guarantee data is not reingested when the journald input is restarted
4 participants
@belimawr @elasticmachine @pierrehilbert @AndersonQ