-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add number_of_routing_shards config set to 30 #5570
Conversation
6eb64e0
to
fd1c914
Compare
The tests complain that:
I think that's currently only an issue in tests, but it does worry me that if anyone is changing I think we should:
|
Setting it to 30, would mean for the once with 1 shard could do |
fd1c914
to
f115314
Compare
f115314
to
64c4447
Compare
With elastic/elasticsearch#26931 the possibility for splitting shards was introduced. To make use of this feature for indices created with ES >=6.1 the config option `index.number_of_routing_shards` is required. This adds this config option currently set to 30 as it's a multiple of 1, 3 and 5, our current number of default shards in Beats and ES. This allows users with default configs to scale their split their shards. The `number_of_routing_shards` can also be overwritten in the config file.
64c4447
to
1edbd77
Compare
@tsg Can you take a look again. I update it to be 30 by default and also updated PR title and description accordingly. I added it to the reference config and added a test to checked if it can be overwritten. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
With elastic/elasticsearch#26931 the possibility for splitting shards was introduced. To make use of this feature for indices created with ES >=6.1 the config option
index.number_of_routing_shards
is required. This adds this config option currently set to 30 as it's a multiple of 1, 3 and 5, our current number of default shards in Beats and ES. This allows users with default configs to scale their split their shards.The
number_of_routing_shards
can also be overwritten in the config file.