Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Join the logging of the message and the newline into one Write #650

Merged
merged 1 commit into from
Jan 7, 2016

Conversation

andrewkroh
Copy link
Member

Fixes #646

@@ -66,15 +66,13 @@ func (rotator *FileRotator) WriteLine(line []byte) error {
return err
}
}

line = append(line, "\n"...)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this working append(line, '\n')

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using a rune literal would be better in this case. I will update. I made the change.

@ruflin
Copy link
Member

ruflin commented Jan 7, 2016

LGTM

ruflin added a commit that referenced this pull request Jan 7, 2016
Join the logging of the message and the newline into one Write
@ruflin ruflin merged commit e22e626 into elastic:1.1 Jan 7, 2016
@andrewkroh andrewkroh deleted the bugfix/logging-newline branch January 13, 2016 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants