Add support for float type in mapstriface #6870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extracted from elastic#6807
ph
suggested changes
Apr 16, 2018
| func toFloat(key string, data map[string]interface{}) (interface{}, error) { | ||
| emptyIface, exists := data[key] | ||
| if !exists { | ||
| return 0, fmt.Errorf("Key %s not found", key) |
andrewkroh
reviewed
Apr 16, 2018
| return 0, fmt.Errorf("Key %s not found", key) | ||
| } | ||
| switch emptyIface.(type) { | ||
| case float64: |
There was a problem hiding this comment.
+1 on parsing string via strconv.ParseFloat.
There was a problem hiding this comment.
So far we don't need it and it's also not supported in the Int type. I would add it when we need it.
There was a problem hiding this comment.
When I've reviewed this, I've made the same conclusion by look at the int handling.
@andrewkroh @urso for me its not necessary right now, wdyt?
There was a problem hiding this comment.
That’s fine by me to omit it for now. It’s an easy add at any point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #6807