Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update elasticsearch.node_stats to use ReporterV2 #6917

Merged
merged 1 commit into from
Apr 25, 2018

Conversation

ruflin
Copy link
Member

@ruflin ruflin commented Apr 23, 2018

To allow more flexibility the Elasticsearch node_stats metricset is updated to use the ReporverV2 interface. This is a subset of #6807.

  • Test data set for ES 6.2.3 added
  • Reporting of error if json decoding fails
  • Update node_stats integration tests to use reporter interface
  • Update generator to also add metricset info
  • Update data.json for node_stats and index
  • Set namespace as part of registration
  • Add service.name to event

@tsg tsg added review and removed review labels Apr 23, 2018
@ruflin ruflin added in progress Pull request is currently in progress. module review Metricbeat Metricbeat labels Apr 23, 2018
To allow more flexibility the Elasticsearch node_stats metricset is updated to use the ReporverV2 interface. This is a subset of elastic#6807.

* Test data set for ES 6.2.3 added
* Reporting of error if json decoding fails
* Update node_stats integration tests to use reporter interface
* Update generator to also add metricset info
* Update data.json for node_stats and index
* Set namespace as part of registration
* Add service.name to event
@ruflin ruflin removed the in progress Pull request is currently in progress. label Apr 25, 2018
@exekias exekias merged commit b35a7a0 into elastic:master Apr 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants