Reduce libbeat state being hold in beat for dynamic loading modules #7018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Metricbeat/Filebeat modules and inputs require to create a connection to the shared libbeat per go-routine. This requires the beat to keep some libbeat state, in order to connect a module to the pipeline when loading a module dynamically (config reloading/autodiscovery). With this change, the pipeline is passed to the RunnerFactory, This way the libbeat-internal state required for connecting a dynamically loaded module to libbeat is managed by libbeat, not the beat itself.
houndci-bot
reviewed
May 4, 2018
metricbeat/mb/module/factory.go
Outdated
| } | ||
| } | ||
|
|
||
| func (r *Factory) Create(c *common.Config, meta *common.MapStrPointer) (cfgfile.Runner, error) { | ||
| func (r *Factory) Create(p beat.Pipeline, c *common.Config, meta *common.MapStrPointer) (cfgfile.Runner, error) { |
There was a problem hiding this comment.
exported method Factory.Create should have comment or be unexported
filebeat/input/registry.go
Outdated
| @@ -16,7 +16,7 @@ type Context struct { | |||
| DynamicFields *common.MapStrPointer | |||
| } | |||
|
|
|||
| type Factory = func(config *common.Config, outletFactory channel.Factory, context Context) (Input, error) | |||
| type Factory = func(config *common.Config, connector channel.Connector, context Context) (Input, error) | |||
There was a problem hiding this comment.
exported type Factory should have comment or be unexported
filebeat/channel/interface.go
Outdated
|
|
||
| // Outleter is the outlet for an input | ||
| type Outleter interface { | ||
| Close() error | ||
| OnEvent(data *util.Data) bool | ||
| } | ||
|
|
||
| func ConnectTo(pipeline beat.Pipeline, factory Factory) Connector { |
There was a problem hiding this comment.
exported function ConnectTo should have comment or be unexported
|
@exekias All good for me, I am adding a post merge LGTM |
stevea78
pushed a commit
to stevea78/beats
that referenced
this pull request
May 20, 2018
…lastic#7018) Reduce libbeat state being hold in beat for dynamic loading modules Metricbeat/Filebeat modules and inputs require to create a connection to the shared libbeat per go-routine. This requires the beat to keep some libbeat state, in order to connect a module to the pipeline when loading a module dynamically (config reloading/autodiscovery). With this change, the pipeline is passed to the RunnerFactory, This way the libbeat-internal state required for connecting a dynamically loaded module to libbeat is managed by libbeat, not the beat itself.
stevea78
pushed a commit
to stevea78/beats
that referenced
this pull request
May 20, 2018
…lastic#7018) Reduce libbeat state being hold in beat for dynamic loading modules Metricbeat/Filebeat modules and inputs require to create a connection to the shared libbeat per go-routine. This requires the beat to keep some libbeat state, in order to connect a module to the pipeline when loading a module dynamically (config reloading/autodiscovery). With this change, the pipeline is passed to the RunnerFactory, This way the libbeat-internal state required for connecting a dynamically loaded module to libbeat is managed by libbeat, not the beat itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Metricbeat/Filebeat modules and inputs require to create a connection to
the shared libbeat per go-routine. This requires the beat to keep some
libbeat state, in order to connect a module to the pipeline when loading
a module dynamically (config reloading/autodiscovery).
With this change, the pipeline is passed to the RunnerFactory, This way
the libbeat-internal state required for connecting a dynamically loaded
module to libbeat is managed by libbeat, not the beat itself.