Move parts of metricset code to Elasticsearch module #7103
Conversation
ruflin
added
in progress
|
jenkins, test this |
ruflin
force-pushed
the
module-metricset-es
branch
from
bef8824
to
f3f9e0b
Compare
ruflin
added
review
and removed
in progress
This is inspired by elastic#7074. More work is needed.
|
|
||
| const ( | ||
| defaultScheme = "http" | ||
| pathConfigKey = "management_path_prefix" |
There was a problem hiding this comment.
The pathConfigKey was path before. I used management_path_prefix in #7074 because this is the terminology in RabbitMQ.
There was a problem hiding this comment.
Ups, this is a leftover. Changed to path.
|
|
||
| http, err := helper.NewHTTP(base) | ||
| // Get the stats from the local node | ||
| ms, err := elasticsearch.NewMetricSet(base, "/_nodes/_local/stats") |
There was a problem hiding this comment.
Move this path also to its own constant?
There was a problem hiding this comment.
move to a constant. I normally only use constant if it's used more then at least once.
|
For the path change you mentioned: It's not something that is documented in the Elasticsearch module and I hope / assume it's not used as it's not something that can be changed itself in ES. I wonder if we should remove it completely? |
|
Merging it now, and letting the path option removal by now. |
This is inspired by #7074. More work will follow in other PR's.