Filebeat Crawler and Prospector Refactoring #720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruflin
changed the title
ruflin
changed the title
ruflin
force-pushed
the
prospector-stopping
branch
2 times, most recently
from
973cd3d
to
1728607
Compare
| @@ -17,7 +17,6 @@ func readLine(reader processor.LineProcessor) (time.Time, string, int, error) { | |||
|
|
|||
| // Full line read to be returned | |||
| if l.Bytes != 0 && err == nil { | |||
| logp.Debug("harvester", "full line read") | |||
There was a problem hiding this comment.
I removed this line as it generated too much debu output.
| @@ -88,8 +95,12 @@ func (fb *Filebeat) Run(b *beat.Beat) error { | |||
| // Publishes event to output | |||
| go Publish(b, fb) | |||
|
|
|||
| // registrar records last acknowledged positions in all files. | |||
| fb.registrar.Run() | |||
| for { | |||
There was a problem hiding this comment.
We don't need it. Will remove it.
* Start registrar first * Introduce waitgroup for started prospectors. Keep list of prospectors in crawler * Code cleanup
ruflin
force-pushed
the
prospector-stopping
branch
from
e3cd3c7
to
2d5d214
Compare
urso
pushed a commit
that referenced
this pull request
Jan 14, 2016
Filebeat Crawler and Prospector Refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is that crawler, prospector properly shut down.